-
Notifications
You must be signed in to change notification settings - Fork 1.4k
17.10 to main manual #10000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
17.10 to main manual #10000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9347357 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9347357 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9394753 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9394753 * Remove spurious `Ł` character in Italian version string --------- Co-authored-by: Rainer Sigwald <[email protected]>
Fixes AB#2017198 by releasing the handle to the file by disposing the AssemblyInformation deterministically.
YuliiaKovalova
approved these changes
Apr 11, 2024
rainersigwald
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to fast-forward merge this to avoid the GitHub merge commit on top of your merge commit but main
has moved so oh well.
This was referenced Jul 28, 2025
Closed
Closed
This was referenced Aug 4, 2025
Closed
Closed
This was referenced Aug 15, 2025
This was referenced Aug 19, 2025
Closed
Open
This was referenced Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to preserve the commits that were squashed when merged in https://github.com/dotnet/msbuild/pull/9992/commits