Xplat Branch Merge #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building these projects on a case-sensitive file system revealed that the file casing is different on disk. Fixed the reference in csprojs to match the name on disk.
According to MSDN (http://msdn.microsoft.com/en-us/library/7szfhaft.aspx), the single quotes can be left off for "simple alphanumeric strings or boolean values". This is not the case here (it is a property), so we should use single quotes. Note that MSBuild ignores this, but it results in a parser error on Mono's xbuild.
Nuked ThreadingUtilities.cs
Changing Build.Utilities back to Build.Utilities.Core
Fix casing of file references in csprojs
Fixed typos
JaynieBai
added a commit
that referenced
this pull request
Apr 23, 2025
Add opt-in for default channel registrations check
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging master/Xplat
Converting mstest to nunit.