Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Build succeeds even though Errors were raised #8814

Closed
eerhardt opened this issue May 30, 2023 · 1 comment · Fixed by #8954
Closed

[Bug]: Build succeeds even though Errors were raised #8814

eerhardt opened this issue May 30, 2023 · 1 comment · Fixed by #8954
Assignees
@JaynieBai @AR-May
Labels
bug Iteration:2023June Priority:1 Work that is critical for the release, but we could probably ship without triaged

Comments

@eerhardt
Copy link
Member

Issue Description

As part of the dotnet/aspnetcore test build, we are publishing test apps and running them during the build. If the test app doesn't return the correct ExitCode, we fail the build.

However, we've run into situations where raising this Error doesn't fail the build, even though it should. This happens in CI, but we haven't found a case where it happens locally - if the test fails, the build fails locally.

Steps to Reproduce

See the binlog here: aspnetcore-succeeds-buterror.binlog

Here is the MSBuild code raising an error:

https://github.com/dotnet/aspnetcore/blob/81666eef98bd9e8c4d95c1478ebe4d4ba77e61a3/eng/testing/linker/trimmingTests.targets#L121-L125

Expected Behavior

The whole build should fail because an Error occurred during the build.

Actual Behavior

image

Analysis

No response

Versions & Configurations

No response
@eerhardt eerhardt added bug needs-triage Have yet to determine what bucket this goes in. labels May 30, 2023
@JanKrivanek
Copy link
Member

[5/23 9:01 PM] Andrew Casey

Here's a run where the error caused a build failure on mac but not on windows or linux

https://dev.azure.com/dnceng-public/public/_build/results?buildId=283737&view=results

[5/23 9:03 PM] Andrew Casey

binlogs are in MacOS_Test_Logs/Release/build.binlog and Linux_Test_logs/Release/build.binlog in the Artifacts view

@AR-May AR-May added Priority:1 Work that is critical for the release, but we could probably ship without and removed needs-triage Have yet to determine what bucket this goes in. labels Jun 6, 2023
@AR-May AR-May self-assigned this Jun 7, 2023
@rokonec rokonec mentioned this issue Jun 26, 2023
Merged
JaynieBai pushed a commit that referenced this issue Jun 27, 2023
@rokonec
Fix treating log messages from Node same as direct messages (#8954)
265f341 
Fixes #8814

Context
Messages coming from Nodes were handled differently than direct messages, for failing builds purposes.

Changes Made
Treating log messages from Node same as direct messages

Testing
Cant repro the local repro after changes

Notes
This was referenced Aug 16, 2023
Closed
Closed
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaynieBai JaynieBai

@AR-May AR-May

Labels
bug Iteration:2023June Priority:1 Work that is critical for the release, but we could probably ship without triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ContinueOnError false positive rokonec/msbuild
4 participants
@JanKrivanek @eerhardt @JaynieBai @AR-May