Skip to content

[Bug]: ToolTask TaskProcessTerminationTimeout propery initialized but never used #8545

@gpwen

Description

@gpwen

Issue Description

Protected property ToolTask.TaskProcessTerminationTimeout has been initialized but never used. Looks like it meant to be used as the default time-out for terminating external tool.

Steps to Reproduce

Looks like timeout on the following line meant to be ToolTask.TaskProcessTerminationTimeout instead of hard-coding:

int timeout = 5000;

Time-out set by derived class won't work in the current implementation.

Expected Behavior

TaskProcessTerminationTimeout set by derived classes of ToolTask should work.

Actual Behavior

TaskProcessTerminationTimeout set by derived classes of ToolTask does not work.

Analysis

Protected property ToolTask.TaskProcessTerminationTimeout has been initialized but never used. It should be applied as time-out when terminating external tool.

Versions & Configurations

MSBuild version 17.4.1.60106
MSBuild latest

Metadata

Metadata

Assignees

Labels

Priority:2Work that is important, but not critical for the releasebacklogbughelp wantedIssues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim.triaged

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions