-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Description
Issue Description
Protected property ToolTask.TaskProcessTerminationTimeout has been initialized but never used. Looks like it meant to be used as the default time-out for terminating external tool.
Steps to Reproduce
Looks like timeout on the following line meant to be ToolTask.TaskProcessTerminationTimeout instead of hard-coding:
msbuild/src/Utilities/ToolTask.cs
Line 940 in 18fe510
| int timeout = 5000; |
Time-out set by derived class won't work in the current implementation.
Expected Behavior
TaskProcessTerminationTimeout set by derived classes of ToolTask should work.
Actual Behavior
TaskProcessTerminationTimeout set by derived classes of ToolTask does not work.
Analysis
Protected property ToolTask.TaskProcessTerminationTimeout has been initialized but never used. It should be applied as time-out when terminating external tool.
Versions & Configurations
MSBuild version 17.4.1.60106
MSBuild latest