-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Closed
Labels
Area: Our Own BuildProblems affecting the build or build infrastructure of the MSBuild repo itself.Problems affecting the build or build infrastructure of the MSBuild repo itself.Priority:3Work that is nice to haveWork that is nice to havebacklogbugtriaged
Description
Issue Description
Running unit tests in VS leads to some test failures - this should not be a case. VS-centric developer workflow should not be neglected
Classes of problems to tackle:
- Tests using
ExecMSBuild
fail on core: Unit test failures when run from VS #8313 - (Reported by @vlada-shubina) Some
BuildEnvironmentHelper_Tests
fail on core (extra RID in path) - Replacing traits used to skip certain test cases with customTheory
andFact
attributes #8348Shouldly.ShouldAssertException : BuildEnvironmentHelper.Instance.MSBuildToolsDirectory32 should be "C:\Users\jankrivanek\AppData\Local\Temp\lhywa2vr.vir\2dfce9d58278472ea474ec9359cd7edd\MSBuild\Current\Bin" but was "C:\Users\jankrivanek\AppData\Local\Temp\lhywa2vr.vir\2dfce9d58278472ea474ec9359cd7edd\MSBuild\Current\Bin\amd64"
- Tests marked with
TestPlatforms.AnyUnix
run on Windows (and can fail). Can we use Need ability to skip test programmatically xunit/xunit#2073 here? - Replacing traits used to skip certain test cases with customTheory
andFact
attributes #8348 - Test marked with
SkipOnTargetFramework
run on excluded FW (and can fail) Can we use Need ability to skip test programmatically xunit/xunit#2073 here? - Replacing traits used to skip certain test cases with customTheory
andFact
attributes #8348 - StringTool
RetainsLastStringWithGivenHashCode
: Fix .NET 3.5 InternableString.GetHashCode to match the full implementation #8340Shouldly.ShouldAssertException : _cache.GetDebugInfo() should be Microsoft.NET.StringTools.WeakStringCache+DebugInfo (-1703002807) but was Microsoft.NET.StringTools.WeakStringCache+DebugInfo (-1703002806)
-
ProjectItemSpecTooLong
(might be env setup on my machine) - related? MSBuild task tests fail when long-paths enabled #4247 -
ProjectGetterResultsInWindowsDriveEnumerationWarning
on Win (might be path specific?) - fixed by Allow MSBuild tests to access root of drive #7330 -
LogWarningUponProjectInstanceCreationFromDriveEnumeratingContent
&LogWindowsWarningUponProjectInstanceCreationFromDriveEnumeratingContent
(env specific?) - Allow MSBuild tests to access root of drive #7330 -
EvaluationProfiler_Tests
(all) - no repro. (might have been caused by the bug in not unsetting the reverted change waves in tests) -
LogWindowsWarningUponBuildingProjectWithDriveEnumeration
- likely just needs application of the following fix: Add ability to create temp mapped drive for integration tests #8366
ladipro and vlada-shubina
Metadata
Metadata
Assignees
Labels
Area: Our Own BuildProblems affecting the build or build infrastructure of the MSBuild repo itself.Problems affecting the build or build infrastructure of the MSBuild repo itself.Priority:3Work that is nice to haveWork that is nice to havebacklogbugtriaged