Windows message loop manager#9614
Merged
Merged
Conversation
mattleibow
added
platform/windows
area-core-lifecycle
mattleibow
changed the title
PureWeen
approved these changes
Aug 26, 2022
Eilon
added
t/desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Many parts of WinUI window features require injection of a proc into the main message loop. Right now we have bits in Essentials and Core. Also, to get min/max sizes for #4942, we need to set some values in some structs in the message, loop.
To fix all this and to remove the large amount of duplicate code, I am creating a central location that allows for a single message proc to be injected, and then everyone [un]subscribes to the event and responds appropriately.
Tasks: