Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception if users uses incompatible pages #6390

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

PureWeen
Copy link
Member

Description of Change

Currently Shell isn't compatible with TabbedPage, FlyoutPage, NavigationPage. This PR adds an exception message that will help guide the user opposed to just crashing with a confusing error message

Issues Fixed

Fixes #6349

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jsuarezruiz jsuarezruiz added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Apr 22, 2022
@PureWeen PureWeen merged commit b3a2cdc into main Apr 22, 2022
@PureWeen PureWeen deleted the throw_incorrect_shell_pages branch April 22, 2022 12:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabbedPage running on Android Emulator - Unhandled Exception
3 participants