Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blazor] Fix Win UI deployed app #5377

Merged
merged 1 commit into from
Mar 17, 2022
Merged

[Blazor] Fix Win UI deployed app #5377

merged 1 commit into from
Mar 17, 2022

Conversation

javiercn
Copy link
Member

Description of Change

The APIs we were using were not correct, this change updates the code to use alternative APIs that are better suited for this task.

The image below shows the deployed app after this fix:
image

Issues Fixed

Fixes #5024

@javiercn javiercn requested a review from a team as a code owner March 17, 2022 11:36
SteveSandersonMS
SteveSandersonMS approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on tracking this down!

@jsuarezruiz jsuarezruiz added the area-blazor Blazor Hybrid / Desktop, BlazorWebView label Mar 17, 2022
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jfversluis jfversluis mentioned this pull request Mar 17, 2022
Closed
@mattleibow
Copy link
Member

Is this also working in unpackaged apps?

@javiercn
Copy link
Member Author

@mattleibow nope, that's something I discussed yesterday with @Eilon and is something we need to implement.

@mattleibow what are the steps for publishing an unpackaged app? I'm using msbuild /restore /t:Publish /p:TargetFramework=net6.0-windows10.0.19041 /p:configuration=release /p:GenerateAppxPackageOnBuild=true /p:AppxPackageSigningEnabled=true /p:PackageCertificateThumbprint="<Cert Thumbprint>" /p:PackageCertificatePassword="<Cert Password>" for the packaged version.

@mattleibow
Copy link
Member

Check out: #3166

It is a msbuild prop and change to launchSettings.json

Then normal F5 things.

@mattleibow
Copy link
Member

Also, this PR makes a bunch of changes that you can copy: #4460

@mattleibow mattleibow merged commit 59fa841 into main Mar 17, 2022
@mattleibow mattleibow deleted the javiercn/fix-win-ui-deployed-apps branch March 17, 2022 20:25
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TanayParikh TanayParikh TanayParikh approved these changes

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

@mattleibow mattleibow mattleibow approved these changes

@Eilon Eilon Eilon approved these changes

Assignees
No one assigned
Labels
area-blazor Blazor Hybrid / Desktop, BlazorWebView fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running installed .NET MAUI Blazor app fails on Windows
7 participants
@javiercn @jsuarezruiz @mattleibow @Eilon @SteveSandersonMS @TanayParikh @samhouts