Skip to content

Essentials.FilePicker WIP refactored to interface and singleton#4632

Closed
moljac wants to merge 1 commit into
dotnet:mainfrom
Forks4Work-Microsoft-Xamarin:essentials-interfaces-filepicker
Closed

Essentials.FilePicker WIP refactored to interface and singleton#4632
moljac wants to merge 1 commit into
dotnet:mainfrom
Forks4Work-Microsoft-Xamarin:essentials-interfaces-filepicker

Conversation

@moljac
Copy link
Copy Markdown
Contributor

@moljac moljac commented Feb 11, 2022

WORK IN PROGRESS

Description of Change

Implements #

Additions made

  • Adds

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the WinUI, Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@Eilon Eilon added the area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info label Feb 11, 2022
@moljac moljac changed the title Essentials.FilePicker refactored to interface and singleton Essentials.FilePicker WIP refactored to interface and singleton Feb 12, 2022
@rmarinho
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@rmarinho rmarinho self-assigned this Mar 8, 2022
@Redth Redth added this to the 6.0.300-rc.1 milestone Mar 15, 2022
@Redth
Copy link
Copy Markdown
Member

Redth commented Mar 22, 2022

Superceded by #5407

@Redth Redth closed this Mar 22, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants