Skip to content

[Compilation fix][Inflight] Fix PublicAPI.Unshipped.txt duplicate entries and missing MEM0002 suppressions in inflight/Current - #37359

Merged
kubaflo merged 1 commit into
dotnet:inflight/currentfrom
NafeelaNazhir:nafeela-builderrorfix
Aug 12, 2026
Merged

[Compilation fix][Inflight] Fix PublicAPI.Unshipped.txt duplicate entries and missing MEM0002 suppressions in inflight/Current#37359
kubaflo merged 1 commit into
dotnet:inflight/currentfrom
NafeelaNazhir:nafeela-builderrorfix

Conversation

@NafeelaNazhir

@NafeelaNazhir NafeelaNazhir commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description:

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description

#36312 enabled the MemoryAnalyzers Roslyn analyzer at error severity for Controls.Core
on iOS/MacCatalyst (MEM0001–MEM0003: retained events, retain-cycle-prone strong references,
and non-deterministic event teardown). After that merge landed on inflight/current, the
build broke locally in two ways, both fixed here:

1. Duplicate PublicAPI.Unshipped.txt entries (net-ios, net-maccatalyst) — 3 lines each
were duplicated: StructuredItemsViewController2<TItemsView>.UpdateFlowDirection(),
SwipeItems.OnPropertyChanged(string), Label.~Label(). Removed the extra copies.

2. Missing MEM0002 suppressions on fields that are already cleared in their component's
teardown path but weren't annotated:

  • NavigationRenderer: _largeTitleProxyScrollView, _largeTitleObservedScrollView, _largeTitleContentOffsetObserver
  • UIContainerCell: _viewResource
  • MauiCollectionView: _contentOffsetObserver

Added justified [UnconditionalSuppressMessage("Memory", "MEM0002", ...)] attributes citing
each field's actual disposal path.

No functional/runtime behavior change — purely restores the intended state of #36312.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Aug 12, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @@NafeelaNazhir! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Aug 12, 2026
@Ahamed-Ali Ahamed-Ali added the area-testing Unit tests, device tests label Aug 12, 2026
@sheiksyedm
sheiksyedm marked this pull request as ready for review August 12, 2026 14:41
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@sheiksyedm sheiksyedm changed the title [Testing] Fix PublicAPI.Unshipped.txt duplicate entries and missing MEM0002 suppressions in inflight/Current [Compilation fix][Inflight] Fix PublicAPI.Unshipped.txt duplicate entries and missing MEM0002 suppressions in inflight/Current Aug 12, 2026
@kubaflo
kubaflo merged commit 13e1f44 into dotnet:inflight/current Aug 12, 2026
37 of 43 checks passed
@github-actions github-actions Bot added this to the .NET 10 SR11 milestone Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants