[ci-fix-net11] Fix CS0115 build error in ModalHandlerTests.SetupBuilder override - #37030
Merged
kubaflo merged 1 commit intoAug 3, 2026
Conversation
HarishwaranVijayakumar
temporarily deployed
to
copilot-pat-pool
August 3, 2026 08:08 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 37030Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 37030" |
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Hey there @@HarishwaranVijayakumar! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
Bot
added
the
partner/syncfusion
HarishwaranVijayakumar
temporarily deployed
to
copilot-pat-pool
August 3, 2026 08:09 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
HarishwaranVijayakumar
temporarily deployed
to
copilot-pat-pool
August 3, 2026 08:11 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
HarishwaranVijayakumar
temporarily deployed
to
copilot-pat-pool
August 3, 2026 08:13 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
HarishwaranVijayakumar
temporarily deployed
to
copilot-pat-pool
August 3, 2026 08:14 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
area-controls-modal
area-testing
HarishwaranVijayakumar
temporarily deployed
to
copilot-pat-pool
August 3, 2026 08:15 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
sheiksyedm
marked this pull request as ready for review
August 3, 2026 12:02
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an Android CS0115 compile error by aligning the ModalHandlerTests override of SetupBuilder with the updated ModalTests.SetupBuilder signature, enabling proper subclass extensibility for device tests.
Changes:
- Updated
ModalTests.SetupBuilderto beprotected virtualand keep the optionalincludeNavigationViewHandlerparameter. - Updated
ModalHandlerTests.SetupBuilderoverride to match the new base method signature.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/tests/DeviceTests/Elements/Modal/ModalTests.cs | Makes SetupBuilder(bool includeNavigationViewHandler = true) protected virtual so derived test classes can override it without signature mismatch. |
| src/Controls/tests/DeviceTests/Elements/Shell/ShellHandlerSubclasses.Android.cs | Updates ModalHandlerTests override to match the base signature, resolving the CS0115 override error on Android. |
sheiksyedm
changed the title
kubaflo
approved these changes
Aug 3, 2026
PureWeen
pushed a commit
that referenced
this pull request
Aug 3, 2026
<!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Description Flows the remaining CI fixes discovered while validating the automated `net11.0` to Preview 7 merge in #36986 back to `net11.0`. - Adds the missing iOS hosting namespace so the TabbedPage device tests compile. - Makes Avalonia template tests skip template post-action restore and use a test-specific NuGet configuration. Existing approved feeds remain mapped to all packages; NuGet.org is limited to the external `Avalonia*` and `MicroCom.*` dependency families. - Serializes `DispatcherTests` and `MainThreadBridgeTests`, which both mutate the process-global `DispatcherProvider`, preventing the Helix race observed in build 1536641. The modal device-test override fix was removed from this PR after it landed independently in #37030. These remaining fixes produced a successful aggregate `maui-pr` run for #36986 in [build 1536659](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1536659). The source-only version-property merge hardening remains separately tracked by #37019. ## Testing - `Core.UnitTests`: 22 targeted `DispatcherTests` and `MainThreadBridgeTests` passed on .NET 11 RC1 after rebasing. - iOS device-test compilation was validated while fixing #36986. - Avalonia integration scenarios restored through the restricted package-source mapping in successful `maui-pr` build 1536659. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Vally Fixture <vally-fixture@example.invalid> Copilot-Session: 37faae15-0e4c-46fd-9bef-f3006c8aaee8
Vignesh-SF3580
pushed a commit
to Vignesh-SF3580/maui
that referenced
this pull request
Aug 10, 2026
…er override (dotnet#37030) ## Description This pull request fixes a `CS0115` build error on Android caused by a signature mismatch between PR dotnet#36328 and PR dotnet#36109. The `SetupBuilder` method in `ModalTests` is now `protected virtual` and accepts an optional `includeNavigationViewHandler` parameter, which allows subclasses like `ModalHandlerTests` to override it with the same signature. ### Changes - **ModalTests.cs**: Changed `SetupBuilder` to `protected virtual void SetupBuilder(bool includeNavigationViewHandler = true)` for better extensibility. - **ShellHandlerSubclasses.Android.cs**: Updated the override in `ModalHandlerTests` to match the new method signature, ensuring consistency between base and derived test classes. Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com>
Vignesh-SF3580
pushed a commit
to Vignesh-SF3580/maui
that referenced
this pull request
Aug 10, 2026
<!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Description Flows the remaining CI fixes discovered while validating the automated `net11.0` to Preview 7 merge in dotnet#36986 back to `net11.0`. - Adds the missing iOS hosting namespace so the TabbedPage device tests compile. - Makes Avalonia template tests skip template post-action restore and use a test-specific NuGet configuration. Existing approved feeds remain mapped to all packages; NuGet.org is limited to the external `Avalonia*` and `MicroCom.*` dependency families. - Serializes `DispatcherTests` and `MainThreadBridgeTests`, which both mutate the process-global `DispatcherProvider`, preventing the Helix race observed in build 1536641. The modal device-test override fix was removed from this PR after it landed independently in dotnet#37030. These remaining fixes produced a successful aggregate `maui-pr` run for dotnet#36986 in [build 1536659](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1536659). The source-only version-property merge hardening remains separately tracked by dotnet#37019. ## Testing - `Core.UnitTests`: 22 targeted `DispatcherTests` and `MainThreadBridgeTests` passed on .NET 11 RC1 after rebasing. - iOS device-test compilation was validated while fixing dotnet#36986. - Avalonia integration scenarios restored through the restricted package-source mapping in successful `maui-pr` build 1536659. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Vally Fixture <vally-fixture@example.invalid> Copilot-Session: 37faae15-0e4c-46fd-9bef-f3006c8aaee8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a
CS0115build error on Android caused by a signature mismatch between PR #36328 and PR #36109.The
SetupBuildermethod inModalTestsis nowprotected virtualand accepts an optionalincludeNavigationViewHandlerparameter, which allows subclasses likeModalHandlerTeststo override it with the same signature.Changes
SetupBuildertoprotected virtual void SetupBuilder(bool includeNavigationViewHandler = true)for better extensibility.ModalHandlerTeststo match the new method signature, ensuring consistency between base and derived test classes.