Skip to content

[ci] Fix internal build: duplicate .cab signing + missing MicrosoftWixVersion #36879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubaflo merged 2 commits into from
Jul 28, 2026
Merged

[ci] Fix internal build: duplicate .cab signing + missing MicrosoftWixVersion #36879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b436ce1
[ci] Remove duplicate .cab signing entry
rmarinho Jul 28, 2026
8bb555b
[ci] Restore MicrosoftWixVersion property lost in merge
rmarinho Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions eng/Signing.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@
<FileSignInfo Include="ReconnectModal.razor.js" CertificateName="Microsoft400" />
</ItemGroup>

<ItemGroup Label="MSI workload cab signing">
<!-- Sign cab files embedded inside MSI workload packs -->
<FileExtensionSignInfo Include=".cab" CertificateName="Microsoft400" />
</ItemGroup>

<ItemGroup>
<ItemsToSign Include="$(ArtifactsShippingPackagesDir)\**\*.msi" Condition="'$(PostBuildSign)' != 'true'" />
<ItemsToSign Include="$(ArtifactsShippingPackagesDir)**\*.wixpack.zip" Condition="'$(PostBuildSign)' != 'true'" />
Expand Down
1 change: 1 addition & 0 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@
<MicroBuildPluginsSwixBuildDotnetPackageVersion>1.1.87-gba258badda</MicroBuildPluginsSwixBuildDotnetPackageVersion>
<MicrosoftDotNetRemoteExecutorPackageVersion>11.0.0-beta.26365.101</MicrosoftDotNetRemoteExecutorPackageVersion>
<MicrosoftDotNetXUnitExtensionsPackageVersion>11.0.0-beta.26365.101</MicrosoftDotNetXUnitExtensionsPackageVersion>
<MicrosoftWixVersion>6.0.3-dotnet.4</MicrosoftWixVersion>
</PropertyGroup>
<PropertyGroup>
<MicrosoftNETTestSdkPackageVersion>17.6.0</MicrosoftNETTestSdkPackageVersion>
Expand Down
Loading