[net11.0][iOS/macOS] Fix CollectionView, RefreshView, and ScrollView interaction state after IsEnabled toggles by kubaflo · Pull Request #36784 · dotnet/maui

kubaflo · 2026-07-25T09:44:15Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

Forward-ports #36305 and its follow-up regression fix from #36628 to net11.0.

Centralizes the iOS/Mac Catalyst UserInteractionEnabled calculation so IsEnabled and InputTransparent remain synchronized.
Routes the ScrollView, RefreshView, ItemsViewHandler, and ItemsViewHandler2 IsEnabled mappings through ViewHandler.MapIsEnabled, matching [inflight regression][iOS/macOS] Fix CollectionView, RefreshView, and ScrollView interaction state after IsEnabled toggles #36628.
Carries over the Issue34666 UI test update from [inflight regression][iOS/macOS] Fix CollectionView, RefreshView, and ScrollView interaction state after IsEnabled toggles #36628.

Issues Fixed

Addresses #36059 and #36501 for .NET 11.

Validation

dotnet build Microsoft.Maui.BuildTasks.slnf --no-restore --nologo -v:minimal
dotnet build src/Controls/tests/TestCases.iOS.Tests/Controls.TestCases.iOS.Tests.csproj --no-restore --nologo -v:minimal
dotnet build src/Core/tests/DeviceTests/Core.DeviceTests.csproj -p:TargetFramework=net11.0-ios -p:RuntimeIdentifier=iossimulator-arm64 --no-restore --nologo -v:minimal

github-actions · 2026-07-25T09:44:24Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 36784

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 36784"

azure-pipelines · 2026-07-25T09:44:30Z

Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run.

kubaflo · 2026-07-25T09:45:50Z

/azp run

azure-pipelines · 2026-07-25T09:46:06Z

Azure Pipelines: Successfully started running 3 pipeline(s).

Copilot

Pull request overview

This PR forward-ports the iOS/Mac Catalyst interaction fix to net11.0, ensuring InputTransparent is respected when IsEnabled changes (including for wrapper/container hit-testing). This prevents input-transparent layouts from becoming touch-blocking after a parent IsEnabled toggle.

Changes:

Update iOS UpdateIsEnabled for non-UIControl views to respect InputTransparent when setting UserInteractionEnabled.
Update iOS UpdateInputTransparent to keep non-UIControl interaction consistent with both IsEnabled and InputTransparent.
Add iOS device tests covering IsEnabled/InputTransparent combinations and container (WrapperView) hit-testing synchronization.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/Core/tests/DeviceTests/Handlers/View/ViewHandlerTests.iOS.cs	Adds iOS device tests validating interaction behavior for non-`UIControl` views and WrapperView containers across `IsEnabled` toggles.
src/Core/src/Platform/iOS/ViewExtensions.cs	Ensures `UserInteractionEnabled` updates for non-`UIControl` views account for both `IsEnabled` and `InputTransparent`.
src/Core/src/Handlers/View/ViewHandler.cs	Keeps WrapperView container hit-testing synchronized when `IsEnabled` changes or a container is created (iOS/Mac Catalyst).

#36784 review) ViewHandler.MapIsEnabled synchronizes the WrapperView container's hit-testing via MapInputTransparentToContainer, but ScrollView/SearchBar/Editor/RefreshView replace the IsEnabled mapper on iOS and only updated the inner platform view. So an iOS ScrollView/Editor/SearchBar/RefreshView that gets a WrapperView container (Clip, Shadow, or Border) kept the container hit-testable after IsEnabled=false, preserving the reachability bug for those controls (MauiBot NEEDS_CHANGES finding). Expose MapInputTransparentToContainer as internal and call it from each override's iOS MapIsEnabled so the container tracks IsEnabled/InputTransparent uniformly. Add a ScrollView device test asserting the container's UserInteractionEnabled follows IsEnabled through the override mapper. Also fix the stale non-UIControl comment in ViewExtensions (it now combines IsEnabled && !InputTransparent) and the missing trailing newline in ViewHandlerTests.iOS.cs. Note: local net11.0-ios build not feasible in this environment (CoreCLR/workload restore chain); relying on CI for the iOS build + device-test validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d00747b7-96f3-4e7a-8dfb-e3a48db04b2d

kubaflo · 2026-07-26T00:29:24Z

Addressed the review findings in 52b796cbe8e:

❌ Container hit-testing stale for override handlers — the base ViewHandler.MapIsEnabled synced the WrapperView container, but ScrollView/SearchBar/Editor/RefreshView replace the iOS IsEnabled mapper and only updated the inner platform view. Exposed MapInputTransparentToContainer as internal and call it from each override's iOS MapIsEnabled, so the container's UserInteractionEnabled now tracks IsEnabled && !InputTransparent uniformly. Added a ScrollView device test (container reachable-when-disabled regression) following the existing ContainerUserInteractionTracksIsEnabledAndInputTransparent pattern.
⚠️ Stale comment — updated the non-UIControl comment in ViewExtensions.cs to reflect IsEnabled && !InputTransparent.
💡 Trailing newline — added to ViewHandlerTests.iOS.cs.

Note: I couldn't build net11.0-ios locally (CoreCLR/workload restore chain in this environment), so I'm relying on CI for the iOS build + device-test run. Ready for re-review — thanks!

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (4)

src/Core/src/Platform/iOS/ViewExtensions.cs:641

UpdateInputTransparent(UIView, handler, view) still has an early-return for non-editor ITextInput which sets UserInteractionEnabled based only on IsReadOnly/InputTransparent and ignores view.IsEnabled. This can re-enable hit testing for disabled non-UIControl text inputs (and their WrapperView containers) when InputTransparent or container mapping runs.

			if (view is not IEditor && view is ITextInput textInput)
			{
				platformView.UpdateInputTransparent(textInput.IsReadOnly, view.InputTransparent);
				return;
			}

			platformView.UpdateInteractionState(view);
		}

src/Controls/src/Core/Handlers/Items/ItemsViewHandler.cs:35

The ItemsViewHandler mapper override for IsEnabled is guarded by #if IOS, but ItemsViewHandler.iOS.cs is compiled for both iOS and MacCatalyst. As written, MacCatalyst builds won’t call MapIsEnabled, so selection mode and UserInteractionEnabled sync won’t be updated there.

			[Controls.ItemsView.ItemsUpdatingScrollModeProperty.PropertyName] = MapItemsUpdatingScrollMode,
#if IOS
			[nameof(IView.IsEnabled)] = MapIsEnabled,
#endif
		};

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue34666.cs:24

After scrolling, the test waits for the same element ("Baboon") that was already present before scrolling, so it no longer validates that the CollectionView actually scrolled. It should wait for an item that becomes visible only after scrolling (e.g., "Gelada").

	public void CollectionViewScrollsWhenRefreshViewDisabled()
	{
		App.WaitForElement("Baboon");
		App.ScrollDown("CollectionView");
		App.ScrollDown("CollectionView");
		App.WaitForElement("Baboon");
	}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue34666.cs:1

The file-level quarantine symbol was changed to TEST_FAILS_ON_ANDROID, but the issue description (and HostApp issue metadata) indicates the scenario affects Windows as well. Consider using a combined guard so the intent stays accurate.

#if TEST_FAILS_ON_ANDROID

kubaflo · 2026-07-30T16:29:09Z

/azp run maui-pr

kubaflo · 2026-07-30T16:29:10Z

/azp run maui-pr-devicetests

kubaflo · 2026-07-30T16:29:11Z

/azp run maui-pr-uitests

azure-pipelines · 2026-07-30T16:29:15Z