[inflight regression] Fix Shell UI tests are failing in Candidate PR - #36673
Merged
Conversation
Dhivya-SF4094
had a problem deploying
to
copilot-pat-pool
July 20, 2026 10:46 — with
GitHub Actions
Failure
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
/azp run maui-pr-uitests , maui-pr-devicetests |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
sheiksyedm
marked this pull request as ready for review
July 20, 2026 14:27
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Open
3 tasks
This was referenced Jul 21, 2026
This was referenced Aug 5, 2026
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
Description of Change
The fix ensures a clear distinction between user-defined Shell.Title values and renderer-mirrored values while preserving the behavior introduced in PR #35800.
ShellToolbar.cs
Retained the existing mirroring behavior, but made the intent explicit by mirroring the current page title only when !IsTitleSetByUser().
Window.cs
Updated ITitledElement.Title to use GetUserSetTitle() instead of directly accessing Shell.Title. This prevents renderer-mirrored values from being used as the native window title while continuing to honor explicitly assigned Shell.Title values.
This approach resolves the regression at the point where it affects native window behavior (Window.cs) without changing the TitleView binding functionality introduced in PR #35800.
Validated the behaviour in the following platforms
Issues Fixed:
Fixes #36562
Screenshots