Fix UsesReflectionBasedBindingsWhenCompilationOfBindingsWithSourceIsDisabled Xaml.UnitTests fails in candidate branch - #36592
Merged
kubaflo merged 2 commits intoJul 15, 2026
Conversation
…nOfBindingsWithSourceIsDisabled
KarthikRajaKalaimani
had a problem deploying
to
copilot-pat-pool
July 15, 2026 13:53 — with 
GitHub Actions
Failure
GitHub Actions
Failure
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Hey there @@KarthikRajaKalaimani! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
Bot
added
the
partner/syncfusion
sheiksyedm
marked this pull request as ready for review
July 15, 2026 14:19
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
kubaflo
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details:
UsesReflectionBasedBindingsWhenCompilationOfBindingsWithSourceIsDisabled test case is failed
Root Cause:
PR #35798 introduced a guard in SetPropertiesVisitor.cs to stop XamlC from compiling a TypedBinding whenever Source is RelativeSource / x:Reference and x:DataType isn't declared directly on the binding node ( !xDataTypeIsOnBindingNode ). The problem: this condition is too broad. It was meant to catch one specific dangerous case — x:DataType inherited from an enclosing DataTemplate , which describes the template item type, not the actual RelativeSource / x:Reference target — but it also caught a harmless case: x:DataType inherited from a plain ancestor like ContentPage (no DataTemplate involved), where the inherited type is still perfectly valid to bind against directly.
Description of Change:
The guard condition changed from !xDataTypeIsOnBindingNode to xDataTypeIsInOuterScope — a flag already computed earlier in the method, set to true only when the tree-walk to find x:DataType passes through a DataTemplate node. This precisely targets the one case #35798 actually needed to guard against (DataTemplate-inherited types being wrongly applied to a RelativeSource/x:Reference target), while leaving alone the case where x:DataType is inherited from a normal ancestor (like ContentPage ) or declared directly on the binding node — both of which can safely use the resolved dataTypeNode type as-is.
Tested the behavior in the following platforms:
Reference:
N/A
Issues Fixed:
Fixes #36563