-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix inconsistent Grouped CollectionView (GridItemsLayout) rendering on Windows and iOS/macOS #36561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kubaflo
merged 7 commits into
dotnet:inflight/current
from
Shalini-Ashokan:fix-35700-Windows
Jul 20, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6df4373
Fixed the collection view measure item issue
Shalini-Ashokan 68d791c
Modified the fix
Shalini-Ashokan eb38e5d
Fixed the item spacing issue on iOS platfrom
Shalini-Ashokan 73dfe84
Moved the item spacing logics to common.
Shalini-Ashokan f55f918
Added the test cases
Shalini-Ashokan b8d57e4
Addressed the AI concerns
Shalini-Ashokan d870aa2
Committed the base images
Shalini-Ashokan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+1.28 KB
(110%)
...oid.Tests/snapshots/android/GroupedCollectionViewGridLayoutRendersCorrectly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+16 KB
...ses.Mac.Tests/snapshots/mac/GroupedCollectionViewGridLayoutRendersCorrectly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+16.2 KB
...nUI.Tests/snapshots/windows/GroupedCollectionViewGridLayoutRendersCorrectly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+26.9 KB
....iOS.Tests/snapshots/ios-26/GroupedCollectionViewGridLayoutRendersCorrectly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+26.9 KB
...ses.iOS.Tests/snapshots/ios/GroupedCollectionViewGridLayoutRendersCorrectly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[major] Cross-Platform Behavioral Consistency / Regression Prevention —
VerticalContentAlignment=Stretchis added unconditionally inGetItemContainerStyle(GridItemsLayout), which builds theGridViewItemstyle for every WindowsGridItemsLayout(grouped and non-grouped alike) — there is noIsGroupedcheck anywhere in this file. The regression test added by this PR only covers a grouped grid, so the adjacent non-grouped scenario is unverified: a non-groupedCollectionView/GridItemsLayoutwith items of varying content height per row will now have those items force-stretched vertically to fill the row height instead of the previous top-aligned behavior, changing the rendered appearance for existing non-grouped grids. Consider scoping the stretch to grouped grids only (e.g. applying it from the grouped-items handler path, or gating the setter onItemsView.IsGrouped) so non-grouped Windows grids keep their prior vertical alignment.