[inflight regression] Fix: LifeCycleEvents Fire When Navigating Top Tabs test fails in candidate - #36558
Merged
kubaflo merged 3 commits intoJul 15, 2026
Conversation
Shalini-Ashokan
had a problem deploying
to
copilot-pat-pool
July 14, 2026 06:02 — with
GitHub Actions
Failure
Contributor
|
Hey there @@Shalini-Ashokan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
2 tasks
Contributor
|
/azp run maui-pr-uitests , maui-pr-devicetests |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
sheiksyedm
marked this pull request as ready for review
July 15, 2026 14:27
Contributor
|
/azp run maui-pr-uitests , maui-pr-devicetests |
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
This pull request fixes a regression Introduced by PR #34351 which caused the Windows device test LifeCycleEvents Fire When Navigating Top Tabs to fail in Candidate PR
Description of Change
PR #34351 added code that fires the OnNavigatingFrom event, but only after the page had already switched to the new one. So it wrongly captured the new page as previous, instead of the old page.
On Windows, we now fire the OnNavigatingFrom event first, before switching the page. This way it correctly captures the old page as previous. Then we switch the page in a special way that tells the shared code "this is already handled," so it doesn't repeat the same mistake.
Issues Fixed
Fixes #36466