Skip to content

[inflight regression] Fix: LifeCycleEvents Fire When Navigating Top Tabs test fails in candidate - #36558

Merged
kubaflo merged 3 commits into
dotnet:inflight/candidatefrom
Shalini-Ashokan:Candidate-Failure-34351
Jul 15, 2026
Merged

[inflight regression] Fix: LifeCycleEvents Fire When Navigating Top Tabs test fails in candidate #36558
kubaflo merged 3 commits into
dotnet:inflight/candidatefrom
Shalini-Ashokan:Candidate-Failure-34351

Conversation

@Shalini-Ashokan

Copy link
Copy Markdown
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

This pull request fixes a regression Introduced by PR #34351 which caused the Windows device test LifeCycleEvents Fire When Navigating Top Tabs to fail in Candidate PR

Description of Change

PR #34351 added code that fires the OnNavigatingFrom event, but only after the page had already switched to the new one. So it wrongly captured the new page as previous, instead of the old page.

On Windows, we now fire the OnNavigatingFrom event first, before switching the page. This way it correctly captures the old page as previous. Then we switch the page in a special way that tells the shared code "this is already handled," so it doesn't repeat the same mistake.

Issues Fixed

Fixes #36466

@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Jul 14, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @@Shalini-Ashokan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jul 14, 2026
@sheiksyedm

Copy link
Copy Markdown
Contributor

/azp run maui-pr-uitests , maui-pr-devicetests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@Shalini-Ashokan Shalini-Ashokan changed the title [inflight regression] Fix: LifeCycleEvents Fire When Navigating Top Tabs test fails in candidate [WIP] [inflight regression] Fix: LifeCycleEvents Fire When Navigating Top Tabs test fails in candidate Jul 14, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@sheiksyedm sheiksyedm changed the title [WIP] [inflight regression] Fix: LifeCycleEvents Fire When Navigating Top Tabs test fails in candidate [inflight regression] Fix: LifeCycleEvents Fire When Navigating Top Tabs test fails in candidate Jul 15, 2026
@sheiksyedm
sheiksyedm marked this pull request as ready for review July 15, 2026 14:27
@sheiksyedm

Copy link
Copy Markdown
Contributor

/azp run maui-pr-uitests , maui-pr-devicetests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@sheiksyedm
sheiksyedm requested a review from kubaflo July 15, 2026 14:28
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@kubaflo
kubaflo merged commit a4a37ac into dotnet:inflight/candidate Jul 15, 2026
53 of 167 checks passed
@github-actions github-actions Bot added this to the .NET 10 SR10 milestone Jul 15, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants