Skip to content

[iOS] NavigationPage: Fix large-title collapse for wrapped scroll content #36511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubaflo merged 11 commits into from
Aug 9, 2026
Merged

[iOS] NavigationPage: Fix large-title collapse for wrapped scroll content #36511

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1c3baaf
Fix iOS non-Shell large title collapse
jfversluis Jul 10, 2026
f3df717
Fix non-Shell large title test build
jfversluis Jul 10, 2026
1d30e1c
Avoid iOS-specific type ambiguity in large title test
jfversluis Jul 10, 2026
ec19807
Adjust non-Shell large title regression
jfversluis Jul 10, 2026
a2fc6e0
Fix iOS 26 large titles in root layouts
jfversluis Jul 10, 2026
6708195
Cover wrapped iOS large title layouts
jfversluis Jul 10, 2026
72a940e
Preserve non-top safe areas for large titles
jfversluis Jul 11, 2026
9de9c88
Handle dynamic iOS large-title content
jfversluis Jul 15, 2026
08208d6
Track iOS large-title safe-area overrides
jfversluis Jul 15, 2026
1ac530d
[iOS] Fix wrapped non-Shell large title collapse
Copilot Aug 8, 2026
b1da04e
[iOS] Harden wrapped large-title scroll discovery
Copilot Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Compatibility/Core/src/iOS/Renderers/NavigationRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,7 +1160,7 @@ void HandleChildPropertyChanged(object sender, PropertyChangedEventArgs e)
if (e.PropertyName == NavigationPage.HasNavigationBarProperty.PropertyName)
UpdateNavigationBarVisibility(true);
else if (e.PropertyName == Page.TitleProperty.PropertyName)
NavigationItem.Title = Child.Title;
UpdateTitle(Child.Title);
else if (e.PropertyName == NavigationPage.HasBackButtonProperty.PropertyName)
UpdateHasBackButton();
else if (e.PropertyName == PrefersStatusBarHiddenProperty.PropertyName)
Expand Down Expand Up @@ -1266,10 +1266,16 @@ internal void UpdateLeftBarButtonItem(Page pageBeingRemoved = null)

internal void UpdateBackButtonTitle(Page page) => UpdateBackButtonTitle(page.Title, NavigationPage.GetBackButtonTitle(page));

void UpdateTitle(string title)
Comment thread
kubaflo marked this conversation as resolved.
Outdated
{
Title = title;
NavigationItem.Title = title;
}

internal void UpdateBackButtonTitle(string title, string backButtonTitle)
{
if (!string.IsNullOrWhiteSpace(title))
NavigationItem.Title = title;
UpdateTitle(title);

if (backButtonTitle != null)
// adding a custom event handler to UIBarButtonItem for navigating back seems to be ignored.
Expand Down
Loading
Loading