Skip to content

[ci-fix-net11] De-flake iOS keyboard-scrolling UI test helper (NoSuchElementException race on EditorsScrollingPageTest) #36404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
+29 −4
Closed

[ci-fix-net11] De-flake iOS keyboard-scrolling UI test helper (NoSuchElementException race on EditorsScrollingPageTest) #36404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/KeyboardScrolling.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,20 +108,45 @@ internal static void HideKeyboard(IApp app, AppiumDriver? driver, bool isEditor)
app.DismissKeyboard();
}

// Polls for a keyboard-related element using the non-throwing FindElements API instead of a
// bare FindElement. On iOS the soft keyboard (and its buttons) can still be animating in when
// the lookup runs, so a bare FindElement throws NoSuchElementException intermittently. Returns
// null if the element never appears within the timeout so callers can react deterministically.
// See dotnet/maui#36396 and dotnet/maui#36393.
static AppiumElement? WaitForKeyboardElement(AppiumDriver? driver, OpenQA.Selenium.By locator, TimeSpan? timeout = null)
{
if (driver is null)
return null;

timeout ??= TimeSpan.FromSeconds(5);
var start = DateTime.Now;
while (true)
{
var elements = driver.FindElements(locator);
if (elements.Count > 0)
return elements[0];

if (DateTime.Now - start >= timeout.Value)
return null;

System.Threading.Thread.Sleep(200);
}
}

internal static System.Drawing.Point? FindiOSKeyboardLocation(AppiumDriver? driver)
{
if (driver?.IsKeyboardShown() == true)
{
var keyboard = driver.FindElement(MobileBy.ClassName("UIAKeyboard"));
return keyboard.Location;
var keyboard = WaitForKeyboardElement(driver, MobileBy.ClassName("UIAKeyboard"));
return keyboard?.Location;
}
return null;
}

internal static void CloseiOSEditorKeyboard(IApp app, AppiumDriver? driver)
{
var doneButtonName = app is AppiumIOSApp iosApp && HelperExtensions.IsIOS26OrHigher(iosApp) ? "selected" : "Done";
var keyboardDoneButton = driver?.FindElement(MobileBy.Name(doneButtonName));
var keyboardDoneButton = WaitForKeyboardElement(driver, MobileBy.Name(doneButtonName));

@MauiBot MauiBot Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 AI-Generated Review (multi-model)

[major] UI Test Reliability — WaitForKeyboardElement can now time out and return null, but CloseiOSEditorKeyboard still treats the Done/selected key as optional via the following null-conditional click. If the accessory button never appears, the helper silently leaves the keyboard open and the test either fails later in an unrelated place or can continue with the wrong state. Please assert/fail when this required keyboard button is missing (for example ClassicAssert.NotNull(keyboardDoneButton, ...)) before clicking it.

keyboardDoneButton?.Click();
}

Expand All @@ -148,7 +173,7 @@ internal static void EntryNextEditorScrollingTest(IApp app, string galleryName)
// Unintentionally types a 'V' but also presses the next keyboard key
internal static void NextiOSKeyboardPress(AppiumDriver? driver)
{
var keyboard = driver?.FindElement(MobileBy.ClassName("UIAKeyboard"));
var keyboard = WaitForKeyboardElement(driver, MobileBy.ClassName("UIAKeyboard"));

@MauiBot MauiBot Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 AI-Generated Review (multi-model)

[major] UI Test Reliability — This lookup now returns null on timeout, but NextiOSKeyboardPress still makes the required Next action optional via keyboard?.SendKeys on the next line. In EntryNextEditorScrollingTest, failing to press Next can leave focus on the previous field while later visibility checks keep running, which hides the real keyboard failure. Please fail immediately when the keyboard is not found before sending the newline.

keyboard?.SendKeys("\n");
}

Expand Down
Loading