Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CV2][iOS] Fix MeasureFirstItem measuring non-first cells #36159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
[CV2][iOS] Fix MeasureFirstItem measuring non-first cells #36159
Changes from all commits
11c7d01c282818File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[major] Regression Prevention / Platform Scoping — Platform guard uses
||instead of&&. With#if TEST_FAILS_ON_WINDOWS || TEST_FAILS_ON_ANDROID, the condition is true (and the test compiles in) whenever either symbol is defined — that means the test runs on Android (TEST_FAILS_ON_ANDROID defined → true) and on Windows (TEST_FAILS_ON_WINDOWS defined → true), the opposite of the intent. The established pattern across the repo (Issue31377.cs, Issue21886.cs, Issue28416.cs) is&&:#if TEST_FAILS_ON_WINDOWS && TEST_FAILS_ON_ANDROID // iOS/MacCatalyst-specific CV2 handler behaviorThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[major] Regression Prevention — Flaky Assertion —
App.WaitForElement("35859Summary").GetText()only waits for the element to exist (it already does from page load). After tapping35859ScrollTo40Button, measurement recording fires asynchronously and thenDispatcher.Dispatch(UpdateSummary)updates the label text; reading.GetText()immediately can return the pre-scroll text, making the assertion pass spuriously or fail intermittently. UseApp.WaitForTextToBePresentInElement("35859Summary", "Items2 CV2: 0 cached-height non-first")to block until the expected value appears:Uh oh!
There was an error while loading. Please reload this page.