Revert - Fix Android stale ContainerView root leak #35372 - #36152
Merged
kubaflo merged 1 commit intoJun 30, 2026
Conversation
Contributor
|
Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
Bot
added
the
partner/syncfusion
TamilarasanSF4853
temporarily deployed
to
gh-aw-agents
June 26, 2026 09:13 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
TamilarasanSF4853
temporarily deployed
to
gh-aw-agents
June 26, 2026 09:13 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
/azp run maui-pr-devicetests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sheiksyedm
changed the title
sheiksyedm
marked this pull request as ready for review
June 30, 2026 06:20
This reverts commit 759c988.
TamilarasanSF4853
force-pushed
the
revert-35372
branch
from
June 30, 2026 07:04
e46ba7f to
e3e1ab7
Compare
Contributor
|
/azp run maui-pr-devicetests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PureWeen
pushed a commit
that referenced
this pull request
Jul 6, 2026
…ss-repo refs Round-2 adversarial review surfaced two verified false-green paths in the closed-fix-unlinked Tier-3 classifier: 1. Manual/hand-authored reverts (e.g. #36152 reverting #35372) carry neither GitHub's quoted 'Revert "..."' subject nor a 'This reverts commit <sha>' body line, so Get-RevertedPrFromSubject returned null. revertedPrSet then recorded only the revert PR; the reverted fix's original commit still satisfied the on-branch gate, and a 'fixed by #35372' comment on a CLOSED issue was falsely de-noised. Add a third, anchored pattern for the 'Revert - <title> #N (#M)' form that recovers the reverted PR (#N) while never returning the revert's own trailing (#M). 2. Scheme-less cross-repo paths ('dotnet/runtime/pull/N', no github.com host, no #) matched the bare 'pull/' alternative and were mistaken for maui#N. Add a 'pathrepo' owner/repo group before the bare 'pull/' alternative and skip when it names a foreign repo; same-repo scheme-less paths are still accepted. Adds 6 regression tests (4 revert-subject, 2 scheme-less cross-repo). Suite 824/0. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Jul 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android, control device test cases are failing in the candidate PR #35716 in CI, but it is not showing which tests are failing. When checking locally, the SwappingDetailPageWorksForSplitFlyoutBehavior test crashed. After reverting PR #35372, the SwappingDetailPageWorksForSplitFlyoutBehavior test no longer crashed. To confirm this, the changes from PR #35372 were reverted to identify the cause of the failures.
Note: Do not merge this PR