Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions src/Graphics/src/Graphics/Color.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ namespace Microsoft.Maui.Graphics
/// </summary>
[DebuggerDisplay("Red={Red}, Green={Green}, Blue={Blue}, Alpha={Alpha}")]
[TypeConverter(typeof(Converters.ColorTypeConverter))]
[ImmutableObject(true)]
public class Color
{
/// <summary>
Expand Down Expand Up @@ -112,17 +113,7 @@ public override string ToString()
return $"[Color: Red={r}, Green={g}, Blue={b}, Alpha={a}]";
}

public override int GetHashCode()
{
unchecked
{
int hashcode = Red.GetHashCode();
hashcode = (hashcode * 397) ^ Green.GetHashCode();
hashcode = (hashcode * 397) ^ Blue.GetHashCode();
hashcode = (hashcode * 397) ^ Alpha.GetHashCode();
return hashcode;
}
}
public override int GetHashCode() => ToInt();

public override bool Equals(object obj)
{
Expand Down
21 changes: 21 additions & 0 deletions src/Graphics/tests/Graphics.Tests/ColorUnitTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@ namespace Microsoft.Maui.Graphics.Tests
{
public class ColorUnitTests
{
sealed class DerivedColor : Color
{
public DerivedColor(float red, float green, float blue, float alpha)
: base(red, green, blue, alpha)
{
}
}

[Fact]
public void TestHSLPostSetEquality()
{
Expand Down Expand Up @@ -138,6 +146,19 @@ public void TestHashCode()
Assert.True(color1.GetHashCode() == color2.GetHashCode());
}

[Fact]
public void EqualsDerivedColorWithSameArgbValue()
{
Color baseColor = new Color(1f, 0f, 0f, 1f);
Color derivedColor = new DerivedColor(1f, 0f, 0f, 1f);

Assert.Equal(baseColor.ToInt(), derivedColor.ToInt());
Assert.True(baseColor.Equals(derivedColor));
Assert.True(derivedColor.Equals(baseColor));
Assert.True(EqualityComparer<Color>.Default.Equals(baseColor, derivedColor));
Assert.Equal(baseColor.GetHashCode(), derivedColor.GetHashCode());
}

[Fact]
public void TestHashCodeNamedColors()
{
Expand Down
Loading