Fix BindableObject.GetLocalValueEnumerator() removed by #33584 breaks VS Live Property Explorer - #36063
Merged
jfversluis merged 2 commits intoJun 24, 2026
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 36063Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 36063" |
devanathan-vaithiyanathan
temporarily deployed
to
gh-aw-agents
June 22, 2026 14:58 — with
GitHub Actions
Inactive
devanathan-vaithiyanathan
temporarily deployed
to
gh-aw-agents
June 22, 2026 15:01 — with
GitHub Actions
Inactive
devanathan-vaithiyanathan
temporarily deployed
to
gh-aw-agents
June 22, 2026 15:02 — with
GitHub Actions
Inactive
sheiksyedm
marked this pull request as ready for review
June 22, 2026 15:02
devanathan-vaithiyanathan
temporarily deployed
to
gh-aw-agents
June 22, 2026 15:03 — with
GitHub Actions
Inactive
This was referenced Jun 23, 2026
Contributor
|
@kubaflo This PR addresses the regression caused by PR #33584, which has already been included in the main branch. The fix is straightforward, as it restores code that was previously removed from PR #33584 because it appeared to be unused, but is actually accessed through reflection. Therefore, this PR can be merged directly into the main branch instead of going through the inflight branch. |
kubaflo
previously approved these changes
Jun 24, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jfversluis
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue details:
After PR #33584 (BindableObject property access micro-optimizations), Visual Studio's Live Property Explorer stops showing any property values for MAUI controls. The feature becomes completely blank.
Description of changes:
PR #33584 removed GetLocalValueEnumerator(), LocalValueEnumerator, and LocalValueEntry from BindableObject as "unused dead code" — a grep of the MAUI codebase confirmed zero internal callers. However, Visual Studio's Live Property Explorer calls GetLocalValueEnumerator() via reflection at runtime to enumerate locally-set bindable property values on live objects. With these types removed, the reflection call fails silently and the panel shows nothing.
This changes restores all three types, adapted to the new Dictionary<int, BindablePropertyContext> storage introduced by #33584 — the enumerator now iterates .Values (the BindablePropertyContext objects directly) and reads context.Property to expose the BindableProperty, since the dictionary key is now an int rather than the property itself.
Tested the behavior in the following platforms.
Before.mp4
After.mp4