Revert environment: gating on review-trigger.yml - #36005
Merged
Merged
Conversation
The OIDC federated credential on the Testing-MI-gh2zdo managed identity doesn't have a subject for the gh-aw-agents environment, causing AADSTS700213 on every /review command. Revert to repo-level AZDO_TRIGGER_* secrets until the federated credential is updated. Fixes the /review trigger broken by #35974. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 36005Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 36005" |
kubaflo
previously approved these changes
Jun 18, 2026
github-actions
Bot
added
the
area-infrastructure
PureWeen
force-pushed
the
pureween/fuzzy-goggles
branch
2 times, most recently
from
June 18, 2026 20:16
3977da7 to
119d8aa
Compare
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Summary
Removes
environment: gh-aw-agentsfrom thetrigger-reviewjob inreview-trigger.yml.Why
PR #35974 added
environment: gh-aw-agentstoreview-trigger.yml, which changed the GitHub OIDC token subject fromrepo:dotnet/maui:ref:refs/heads/maintorepo:dotnet/maui:environment:gh-aw-agents. The managed identity (Testing-MI-gh2zdo) behindAZDO_TRIGGER_CLIENT_IDhas no federated credential for that environment subject, so every/reviewcommand fails with:The
AZDO_TRIGGER_*secrets have been re-added at the repo level. Once the federated credential is updated (requires Azure access to the managed identity), the environment gating can be re-added.What changed
environment: gh-aw-agentsfrom thetrigger-reviewjob (1 line)review-trigger.yml(regular GHA) is affected