Skip to content

Fix dogfood PR artifact retrieval for failed aggregate builds - #35939

Merged
jfversluis merged 1 commit into
mainfrom
jfversluis/fix-dogfood-artifacts
Jun 24, 2026
Merged

Fix dogfood PR artifact retrieval for failed aggregate builds#35939
jfversluis merged 1 commit into
mainfrom
jfversluis/fix-dogfood-artifacts

Conversation

@jfversluis

Copy link
Copy Markdown
Member

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description

Updates eng/scripts/get-maui-pr.sh and eng/scripts/get-maui-pr.ps1 so users can still apply PR package artifacts when the aggregate maui-pr build is red because of unrelated CI legs, as long as the package-producing artifacts exist for the current PR commit.

Changes

  • Treat a red aggregate maui-pr build as a warning instead of an immediate abort.
  • Keep PackageArtifacts as the hard gate before downloading/applying packages.
  • Filter AzDO fallback builds to the current PR head/merge context using triggerInfo.pr.sourceSha, sourceVersion, and the PR merge SHA.
  • Warn when Pack macOS or Pack Windows timeline records do not report success.
  • Update troubleshooting text to refer to completed maui-pr builds with PackageArtifacts rather than green checks.

Validation

  • bash -n eng/scripts/get-maui-pr.sh
  • PowerShell parser validation for eng/scripts/get-maui-pr.ps1
  • git diff --check
  • Local throwaway MAUI projects under /Volumes/NieuwVolume/maui-pr-artifact-verification-20260616101523:
    • PR #35805: red aggregate build 1461390, PackageArtifacts present, pack jobs succeeded; Bash and PowerShell scripts applied package 10.0.80-ci.pr35805.26312.37; dotnet restore succeeded.
    • PR #35923: green aggregate build path applied package 10.0.80-ci.pr35923.26315.57; dotnet restore succeeded.
    • PR #35626: missing PackageArtifacts failed before mutating the project.
    • PR #999999: nonexistent PR failed cleanly during PR lookup.
    • Wrong-SHA harness for PR #35805: refused to use older completed builds when none matched the requested head/merge commit.

Allow get-maui-pr scripts to continue when the aggregate maui-pr build is red but PackageArtifacts are available for the current PR commit.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35939

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35939"

@github-actions github-actions Bot added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Jun 16, 2026
@jfversluis
jfversluis merged commit 1a72239 into main Jun 24, 2026
33 of 36 checks passed
@jfversluis
jfversluis deleted the jfversluis/fix-dogfood-artifacts branch June 24, 2026 08:40
@github-actions github-actions Bot added this to the .NET 10 SR9 milestone Jun 24, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant