-
Notifications
You must be signed in to change notification settings - Fork 2k
[Net11]Improve label mapping performance and ensure complete coverage including ToPlatform and subsequent property changes #35892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 25 commits
bbfe8d6
9a5bd7c
8a456a6
c95ea7a
3a190bd
19a1427
21456c3
3a034d9
ed41541
0689b93
dba4e70
58d1d6a
90ce53d
35ad904
e5ba479
a39880c
4156c76
09c0f20
dcbca33
bfd16b5
b9cd676
9441ea3
ea14b30
6eea165
43afeec
17c9127
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,15 +18,15 @@ public partial class Entry | |
| EntryHandler.Mapper.ReplaceMapping<Entry, IEntryHandler>(PlatformConfiguration.iOSSpecific.Entry.AdjustsFontSizeToFitWidthProperty.PropertyName, MapAdjustsFontSizeToFitWidth); | ||
| #endif | ||
| EntryHandler.Mapper.ReplaceMapping<Entry, IEntryHandler>(nameof(Text), MapText); | ||
| EntryHandler.Mapper.ReplaceMapping<Entry, IEntryHandler>(nameof(TextTransform), MapText); | ||
| EntryHandler.Mapper.ReplaceMapping<Entry, IEntryHandler>(nameof(TextTransform), MapTextTransform); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [moderate] Android Platform / Mapper Lifecycle — This changes the
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [major] Handler Mapper and Property Patterns — The guarded |
||
|
|
||
| // Material3 Entry Handler mappings | ||
| #if ANDROID | ||
| if (RuntimeFeature.IsMaterial3Enabled) | ||
| { | ||
| EntryHandler2.Mapper.ReplaceMapping<Entry, EntryHandler2>(PlatformConfiguration.AndroidSpecific.Entry.ImeOptionsProperty.PropertyName, MapImeOptions); | ||
| EntryHandler2.Mapper.ReplaceMapping<Entry, EntryHandler2>(nameof(Text), MapText); | ||
| EntryHandler2.Mapper.ReplaceMapping<Entry, EntryHandler2>(nameof(TextTransform), MapText); | ||
| EntryHandler2.Mapper.ReplaceMapping<Entry, EntryHandler2>(nameof(TextTransform), MapTextTransform); | ||
|
devanathan-vaithiyanathan marked this conversation as resolved.
|
||
| EntryHandler2.Mapper.AppendToMapping(nameof(VisualElement.IsFocused), InputView.MapIsFocused); | ||
| EntryHandler2.Mapper.AppendToMapping(nameof(VisualElement.IsVisible), InputView.MapIsVisible); | ||
| EntryHandler2.CommandMapper.PrependToMapping(nameof(IEntry.Focus), InputView.MapFocus); | ||
|
|
@@ -42,5 +42,16 @@ public partial class Entry | |
| EntryHandler.CommandMapper.PrependToMapping(nameof(IEntry.Focus), InputView.MapFocus); | ||
| #endif | ||
| } | ||
|
|
||
| static void MapTextTransform(IEntryHandler handler, Entry entry) | ||
|
devanathan-vaithiyanathan marked this conversation as resolved.
devanathan-vaithiyanathan marked this conversation as resolved.
|
||
| { | ||
| if (entry.IsConnectingHandler()) | ||
| { | ||
| // If we're connecting the handler, we don't want to map the text multiple times. | ||
| return; | ||
| } | ||
|
|
||
| MapText(handler, entry); | ||
| } | ||
|
devanathan-vaithiyanathan marked this conversation as resolved.
|
||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.