-
Notifications
You must be signed in to change notification settings - Fork 2k
[Android] Fix RadialGradientBrush crash on Android when view has zero size #35781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kubaflo
merged 5 commits into
dotnet:inflight/current
from
SyedAbdulAzeemSF4852:fix-35753
Jun 11, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e904e90
ci: skip provision AVD creation in ci-copilot.yml (inline script owns…
PureWeen 45e2a4d
Stop PR Review Queue workflow from running on forks and @-pinging PR …
PureWeen 1221e4d
[ci] Set __PWSH_LOGIN_CHECKED to avoid macOS pwsh 'procargs failed' s…
PureWeen 7934343
Fix RadialGradientBrush crash on Android when view has zero size
SyedAbdulAzeemSF4852 232eafc
Fix: Move zero-size guard to getShader() with && instead of || to mat…
SyedAbdulAzeemSF4852 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
src/Core/tests/DeviceTests/Graphics/GraphicsTests.Android.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[major] Android graphics/platform API preconditions — This guard only handles the reported zero-width-and-height case, but Android
RadialGradientthrows whenever the computed radius is<= 0. ARadialGradientPaintcan still produce radius 0 with non-zero bounds, for example whenRadiusis 0 or left at the default from constructors that don't initialize it, so this path will still reachnew RadialGradient(..., this.gradientBounds[2] * Math.max(width, height), ...)and crash. Please guard the radial branch on the computed radius before constructingRadialGradientand add coverage for a zero-radius radial gradient.