ci: skip provision AVD creation in ci-copilot.yml (inline script owns it)#35714
Merged
Conversation
… it) When Platform=android, both `ProvisionAndroidSdkAvdCreateAvds` and the inline `avdmanager create avd -n Emulator_30 …` script create the same AVD. Both pass --force, so the second overwrites the first — wasted ~30–60s per run. The inline script is the canonical source of truth: it pins the `google_apis_playstore` image variant, the Nexus 5X profile, the 2048m dataPartition shrink, and ADB key pre-auth. None of those are applied by ProvisionAndroidSdkAvdCreateAvds. Re-pin skipAndroidCreateAvds to true so provisioning skips the duplicate step. ci-copilot.yml only drives the Copilot review pipeline, so this is scoped to that. Reverts the AVD-creation portion of #35376 — the inline script the same PR added already handles AVD creation. Reported by @kubaflo on #35687. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35714Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35714" |
kubaflo
approved these changes
Jun 2, 2026
github-actions
Bot
added
the
area-infrastructure
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Follow-up to @kubaflo's review on #35687.
What
In
eng/pipelines/ci-copilot.yml, whenparameters.Platform == 'android', the Android AVD was being created twice:common/provision.ymlrunning theProvisionAndroidSdkAvdCreateAvdsMSBuild target — becauseskipAndroidCreateAvds: ${{ ne(parameters.Platform, 'android') }}evaluated tofalsefor Android. That target invokesdotnet android avd create --name "Emulator_30" … --force.Create AVD and boot Android Emulatorscript ranavdmanager create avd -n Emulator_30 -k "system-images;android-30;google_apis_playstore;x86_64" --device "Nexus 5X" --force.Both create the same AVD name with
--force, so the second silently overwrites the first — no error, just ~30–60s wasted on every Copilot review pipeline run for Android.The inline script is the canonical source of truth: it pins the
google_apis_playstoreimage variant, theNexus 5Xdevice profile, thedisk.dataPartition.size=2048mshrink, and ADB key pre-auth. None of those are applied byProvisionAndroidSdkAvdCreateAvds. So the right fix is to skip the provision step entirely and let the inline script own AVD creation.Change
Pinned
skipAndroidCreateAvds: true(with an explanatory comment) at both call sites ofcommon/provision.ymlinci-copilot.yml(the ReviewPR stage and the Deep stage). The inlineavdmanagerblocks are untouched.This is the AVD-creation portion of #35376 being reverted — the inline script that same PR added already handles AVD creation, so the provision-step AVD creation was redundant.
Scope
This change is scoped to
ci-copilot.ymlonly — the Copilot review pipeline. It does not touch the required gating pipelines:maui-prmaui-pr-devicetestsmaui-pr-uitestsFollow-up
Needs to be ported to
net11.0afterward via the automatedmerge/main-to-net11.0flow.