[release/10.0.1xx-sr7] Revert PR #30068 — Fix FontImageSource centering regression on Windows#35689
Merged
PureWeen merged 2 commits intoJun 2, 2026
Conversation
#35642) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> This PR reverts the changes introduced by #30068, which caused an FontImageSource is not centered and gets clipped. ### Root cause of Regression PR #30068 introduced a regression in 10.0.60 where Image controls using FontImageSource are no longer centered and get clipped on Windows. The LayoutBounds-based canvas sizing produces a larger canvas than expected, causing glyphs to overflow and appear misaligned in certain scenarios. ### Description of Change PR #30068 fixed glyph centering by switching FontImageSourceService on Windows to use a fontSize × fontSize layout and LayoutBounds for canvas sizing, which caused some font glyphs to be cropped or tightly constrained in certain scenarios. Reverting to restore the previous rendering behavior. ### Issues Fixed Fixes #35618 --------- (cherry picked from commit 9a4b5ec)
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35689Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35689" |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Jun 2, 2026
Open
3 tasks
This was referenced Jun 2, 2026
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
2 tasks
PureWeen
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Backport of #35642 to
release/10.0.1xx-sr7./cc @PureWeen