Skip to content

[Android] Fix MapHandler leaks when removed Pin instances are retained by app code - #35686

Merged
kubaflo merged 6 commits into
dotnet:inflight/currentfrom
SubhikshaSf4851:Fix-35571
Jun 5, 2026
Merged

[Android] Fix MapHandler leaks when removed Pin instances are retained by app code #35686
kubaflo merged 6 commits into
dotnet:inflight/currentfrom
SubhikshaSf4851:Fix-35571

Added suggestion

4afe1e0
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis failed Jun 5, 2026 in 0s

.NET Result Analysis

Details

Tip

To unconditionally bypass the build analysis check (turn it green), you can use the escape mechanism feature. The completion time may vary, potentially taking several minutes, depending on the build analysis workload at the moment.

Build Failures

maui-pr / Build .NET MAUI / Build Windows (Debug) / 🛠️ Build Microsoft.Maui.sln

[ 🚧 Create issue against infrastructure team] [ 📄 Create issue in this repo]
    ❌src\Controls\tests\TestCases.HostApp\Issues\Issue7814.cs(45,30): error CS1061: 'Label' does not contain a definition for 'Column' and no accessible extension method 'Column' accepting a first argument of type 'Label' could be found (are you missing a using directive or an assembly reference?)
    ❌src\Controls\tests\TestCases.HostApp\Issues\Issue7814.cs(48,21): error CS1061: 'ScrollView' does not contain a definition for 'Row' and no accessible extension method 'Row' accepting a first argument of type 'ScrollView' could be found (are you missing a using directive or an assembly reference?)

maui-pr / Build .NET MAUI / Build Windows (Release) / 🛠️ Build Microsoft.Maui.sln

[ 🚧 Create issue against infrastructure team] [ 📄 Create issue in this repo]
    ❌src\Controls\tests\TestCases.HostApp\Issues\Issue7814.cs(45,30): error CS1061: 'Label' does not contain a definition for 'Column' and no accessible extension method 'Column' accepting a first argument of type 'Label' could be found (are you missing a using directive or an assembly reference?)
    ❌src\Controls\tests\TestCases.HostApp\Issues\Issue7814.cs(48,21): error CS1061: 'ScrollView' does not contain a definition for 'Row' and no accessible extension method 'Row' accepting a first argument of type 'ScrollView' could be found (are you missing a using directive or an assembly reference?)

maui-pr / Build .NET MAUI / Build macOS (Debug) / 🛠️ Build Microsoft.Maui.sln

[ 🚧 Create issue against infrastructure team] [ 📄 Create issue in this repo]
    ❌src/Controls/tests/TestCases.HostApp/Issues/Issue7814.cs(45,30): error CS1061: 'Label' does not contain a definition for 'Column' and no accessible extension method 'Column' accepting a first argument of type 'Label' could be found (are you missing a using directive or an assembly reference?)
    ❌src/Controls/tests/TestCases.HostApp/Issues/Issue7814.cs(48,21): error CS1061: 'ScrollView' does not contain a definition for 'Row' and no accessible extension method 'Row' accepting a first argument of type 'ScrollView' could be found (are you missing a using directive or an assembly reference?)

10 other jobs are failing and were not displayed due to space limitations.
Builds with failures: [maui-pr] [maui-pr-devicetests] [maui-pr-uitests]

Test Failures (115 tests failed)

🔹 [All failing tests from maui-pr]

    ⚠️ 56 failing tests not displayed for this pipeline due to space limitations

    ❌ AppConfigurationOverwritesValues [Console] [Details] [Artifacts] [2.02% failure rate]
    [ 🚧 Create issue against infrastructure team] [ 📄 Create issue in this repo]

    Failing Configuration
    Exception Message
    System.ObjectDisposedException : Cannot access a disposed object.
Object name: 'System.Threading.ThreadLocal`1[[Microsoft.Maui.Dispatching.IDispatcher, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]]'.
    CallStack
       at System.Threading.ThreadLocal`1.GetValueSlow()
   at Microsoft.Maui.UnitTests.DispatcherProviderStub.GetForCurrentThread() in /_/src/Core/tests/UnitTests/TestClasses/DispatcherStub.cs:line 108
   at Microsoft.Maui.Dispatching.Dispatcher.GetForCurrentThread() in /_/src/Core/src/Dispatching/Dispatcher.cs:line 9
   at Microsoft.Maui.Hosting.AppHostBuilderExtensions.GetDispatcher(IServiceProvider services, Boolean fallBackToApplicationDispatcher) in /_/src/Core/src/Hosting/Dispatching/AppHostBuilderExtensions.cs:line 169
   at Microsoft.Maui.Hosting.AppHostBuilderExtensions.<>c.<ConfigureDispatching>b__1_1(IServiceProvider svc) in /_/src/Core/src/Hosting/Dispatching/AppHostBuilderExtensions.cs:line 25
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitFactory(FactoryCallSite factoryCallSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.CreateServiceAccessor(ServiceIdentifier serviceIdentifier)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetService[T](IServiceProvider provider)
   at Microsoft.Maui.Hosting.AppHostBuilderExtensions.GetOptionalApplicationDispatcher(IServiceProvider provider) in /_/src/Core/src/Hosting/Dispatching/AppHostBuilderExtensions.cs:line 158
   at Microsoft.Maui.Hosting.AppHostBuilderExtensions.ApplicationDispatcherInitializer.Initialize(IServiceProvider services) in /_/src/Core/src/Hosting/Dispatching/AppHostBuilderExtensions.cs:line 181
   at Microsoft.Maui.MauiContextExtensions.InitializeAppServices(MauiApp mauiApp) in /_/src/Core/src/MauiContextExtensions.cs:line 83
   at Microsoft.Maui.Hosting.MauiAppBuilder.Build() in /_/src/Core/src/Hosting/MauiAppBuilder.cs:line 198
   at Microsoft.Maui.UnitTests.Hosting.HostBuilderAppConfigurationTests.AppConfigurationOverwritesValues() in /_/src/Core/tests/UnitTests/Hosting/HostBuilderAppConfigurationTests.cs:line 48
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
    ❌ BorderStrokeShapeDoesNotLeak [Console] [Details] [Artifacts] [2.94% failure rate]
    [ 🚧 Create issue against infrastructure team] [ 📄 Create issue in this repo]
    This is a helix work item crash with status: BadExit. To investigate look the [Console log] / navigate to [Helix Artifacts]

    Failing Configuration
    ❌ BorderStrokeSubscribed [Console] [Details] [Artifacts] [2.61% failure rate]
    [ 🚧 Create issue against infrastructure team] [ 📄 Create issue in this repo]

    Failing Configuration
    Exception Message
    System.ObjectDisposedException : Cannot access a disposed object.
Object name: 'System.Threading.ThreadLocal`1[[Microsoft.Maui.Dispatching.IDispatcher, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]]'.
    CallStack
       at System.Threading.ThreadLocal`1.GetValueSlow()
   at Microsoft.Maui.UnitTests.DispatcherProviderStub.GetForCurrentThread() in /_/src/Core/tests/UnitTests/TestClasses/DispatcherStub.cs:line 108
   at Microsoft.Maui.Dispatching.Dispatcher.GetForCurrentThread() in /_/src/Core/src/Dispatching/Dispatcher.cs:line 9
   at Microsoft.Maui.Controls.BindableObject..ctor() in /_/src/Controls/src/Core/BindableObject.cs:line 38
   at Microsoft.Maui.Controls.Element..ctor() in /_/src/Controls/src/Core/Element/Element.cs:line 701
   at Microsoft.Maui.Controls.Brush..ctor()
   at Microsoft.Maui.Controls.SolidColorBrush..ctor(Color color) in /_/src/Controls/src/Core/SolidColorBrush.cs:line 19
   at Microsoft.Maui.UnitTests.Views.BorderTests.BorderStrokeSubscribed() in /_/src/Core/tests/UnitTests/Views/BorderTests.cs:line 79
--- End of stack trace from previous location ---
    ❌ CanAddLoggingProviders [Console] [Details] [Artifacts] [1.91% failure rate]
    [ 🚧 Create issue against infrastructure team] [ 📄 Create issue in this repo]

    Failing Configuration
    Exception Message
    System.ObjectDisposedException : Cannot access a disposed object.
Object name: 'System.Threading.ThreadLocal`1[[Microsoft.Maui.Dispatching.IDispatcher, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]]'.
    CallStack
       at System.Threading.ThreadLocal`1.GetValueSlow()
   at Microsoft.Maui.UnitTests.DispatcherProviderStub.GetForCurrentThread() in /_/src/Core/tests/UnitTests/TestClasses/DispatcherStub.cs:line 108
   at Microsoft.Maui.Dispatching.Dispatcher.GetForCurrentThread() in /_/src/Core/src/Dispatching/Dispatcher.cs:line 9
   at Microsoft.Maui.Hosting.AppHostBuilderExtensions.GetDispatcher(IServiceProvider services, Boolean fallBackToApplicationDispatcher) in /_/src/Core/src/Hosting/Dispatching/AppHostBuilderExtensions.cs:line 169
   at Microsoft.Maui.Hosting.AppHostBuilderExtensions.<>c.<ConfigureDispatching>b__1_1(IServiceProvider svc) in /_/src/Core/src/Hosting/Dispatching/AppHostBuilderExtensions.cs:line 25
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitFactory(FactoryCallSite factoryCallSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.CreateServiceAccessor(ServiceIdentifier serviceIdentifier)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetService[T](IServiceProvider provider)
   at Microsoft.Maui.Hosting.AppHostBuilderExtensions.GetOptionalApplicationDispatcher(IServiceProvider provider) in /_/src/Core/src/Hosting/Dispatching/AppHostBuilderExtensions.cs:line 158
   at Microsoft.Maui.Hosting.AppHostBuilderExtensions.ApplicationDispatcherInitializer.Initialize(IServiceProvider services) in /_/src/Core/src/Hosting/Dispatching/AppHostBuilderExtensions.cs:line 181
   at Microsoft.Maui.MauiContextExtensions.InitializeAppServices(MauiApp mauiApp) in /_/src/Core/src/MauiContextExtensions.cs:line 83
   at Microsoft.Maui.Hosting.MauiAppBuilder.Build() in /_/src/Core/src/Hosting/MauiAppBuilder.cs:line 198
   at Microsoft.Maui.UnitTests.Hosting.HostBuilderLoggingTests.CanAddLoggingProviders() in /_/src/Core/tests/UnitTests/Hosting/HostBuilderLoggingTests.cs:line 35
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
    ❌ CanConfigureAppConfiguration [Console] [Details] [Artifacts] [2.07% failure rate]
    [ 🚧 Create issue against infrastructure team] [ 📄 Create issue in this repo]

    Failing Configuration
    Exception Message
    System.ObjectDisposedException : Cannot access a disposed object.
Object name: 'System.Threading.ThreadLocal`1[[Microsoft.Maui.Dispatching.IDispatcher, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]]'.
    CallStack
       at System.Threading.ThreadLocal`1.GetValueSlow()
   at Microsoft.Maui.UnitTests.DispatcherProviderStub.GetForCurrentThread() in /_/src/Core/tests/UnitTests/TestClasses/DispatcherStub.cs:line 108
   at Microsoft.Maui.Dispatching.Dispatcher.GetForCurrentThread() in /_/src/Core/src/Dispatching/Dispatcher.cs:line 9
   at Microsoft.Maui.Hosting.AppHostBuilderExtensions.GetDispatcher(IServiceProvider services, Boolean fallBackToApplicationDispatcher) in /_/src/Core/src/Hosting/Dispatching/AppHostBuilderExtensions.cs:line 169
   at Microsoft.Maui.Hosting.AppHostBuilderExtensions.<>c.<ConfigureDispatching>b__1_1(IServiceProvider svc) in /_/src/Core/src/Hosting/Dispatching/AppHostBuilderExtensions.cs:line 25
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitFactory(FactoryCallSite factoryCallSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.CreateServiceAccessor(ServiceIdentifier serviceIdentifier)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetService[T](IServiceProvider provider)
   at Microsoft.Maui.Hosting.AppHostBuilderExtensions.GetOptionalApplicationDispatcher(IServiceProvider provider) in /_/src/Core/src/Hosting/Dispatching/AppHostBuilderExtensions.cs:line 158
   at Microsoft.Maui.Hosting.AppHostBuilderExtensions.ApplicationDispatcherInitializer.Initialize(IServiceProvider services) in /_/src/Core/src/Hosting/Dispatching/AppHostBuilderExtensions.cs:line 181
   at Microsoft.Maui.MauiContextExtensions.InitializeAppServices(MauiApp mauiApp) in /_/src/Core/src/MauiContextExtensions.cs:line 83
   at Microsoft.Maui.Hosting.MauiAppBuilder.Build() in /_/src/Core/src/Hosting/MauiAppBuilder.cs:line 198
   at Microsoft.Maui.UnitTests.Hosting.HostBuilderAppConfigurationTests.CanConfigureAppConfiguration() in /_/src/Core/tests/UnitTests/Hosting/HostBuilderAppConfigurationTests.cs:line 22
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

🔹 [All failing tests from maui-pr-devicetests]

    ⚠️ 54 failing tests not displayed for this pipeline due to space limitations

Was this helpful? Yes No

View more details on Build Analysis