Update SDK pin to 10.0.108 and align global.json with dotnet repo patterns#35684
Merged
Conversation
- Bump tools.dotnet from stale 10.0.100-rtm.25523.113 to stable 10.0.108 - Add sdk.version field (matches tools.dotnet), aligning with runtime/roslyn/winforms - Add rollForward: patch and allowPrerelease: false for safety (roslyn pattern) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use --arg for proper quoting and update both .tools.dotnet and .sdk.version from eng/Versions.props when Maestro dependency PRs land. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35684Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35684" |
github-actions
Bot
added
the
area-infrastructure
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s .NET SDK pinning in global.json to align with common dotnet repo patterns, ensuring the CLI resolves a known SDK version while keeping the existing toolset pin.
Changes:
- Bump
tools.dotnetfrom10.0.100-rtm.25523.113to10.0.108. - Add
sdk.version(matchingtools.dotnet) plusallowPrerelease: falseandrollForward: "patch"to control SDK selection behavior.
…olution) MAUI's CI uses eng/common/tools.sh to install the SDK into .dotnet/ based on tools.dotnet, then uses sdk.paths for resolution. Adding sdk.version creates a hard CLI constraint that fails in post-build steps where .dotnet/ isn't resolved. Keep only tools.dotnet=10.0.108 (the safe stable version). The workflow jq still uses proper --arg quoting but only sets tools.dotnet. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kubaflo
approved these changes
Jun 1, 2026
This was referenced Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
The
mainbranch SDK pin inglobal.jsonwas stale (10.0.100-rtm.25523.113) and had no automation to keep it updated (no Maestro subscription fromdotnet/dotnettargetsmain).This PR bumps
tools.dotnetto stable10.0.108and fixes thebump-global-json.ymlworkflow to use proper--argquoting.Why not add
sdk.version? MAUI's CI uses customsdk.paths(.dotnet,$host$) witheng/common/tools.shprovisioning. Addingsdk.versioncreates a hard CLI constraint that fails in post-build steps where the.dotnet/path isn't resolved. Other dotnet repos (runtime, roslyn) don't use custom paths, so theirsdk.versionworks fine. MAUI should continue relying only ontools.dotnet.Changes:
tools.dotnetfrom10.0.100-rtm.25523.113to10.0.108(stable)bump-global-json.ymljq to use proper--argquoting (was fragile string interpolation)Context:
net10.0/release branches (which have active Maestro subscriptions)mainwill still need periodic manual SDK bumps unless a Maestro subscription is addedIssues Fixed
N/A - Infrastructure/security hygiene improvement.