-
Notifications
You must be signed in to change notification settings - Fork 2k
[Windows, Android] Fix Border Color and Border Width Not applying for Radio Button #35616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kubaflo
merged 8 commits into
dotnet:inflight/current
from
HarishwaranVijayakumar:fix-35587
May 26, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4408e3e
Add version 10.0.70 to bug report template (#35569)
PureWeen 4306163
Restrict agentic-labeler to exactly one area-* label (#35567)
PureWeen 7c76748
Add deep UI test execution to Copilot PR review pipeline (#35376)
kubaflo b0ea772
[Testing] Fix for flaky UITests in CI that occasionally fail (#35589)
kubaflo 40ccd32
Add fix
HarishwaranVijayakumar f25af81
Add snap
HarishwaranVijayakumar 9c32d88
update fix
HarishwaranVijayakumar 14845b7
Merge branch 'inflight/current' into fix-35587
kubaflo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+23.7 KB
...TestCases.Android.Tests/snapshots/android/RadioButtonBorderAppliedAtRuntime.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 35587, "RadioButton BorderColor and BorderWidth not applied when dynamically updated at runtime", PlatformAffected.Android | PlatformAffected.UWP)] | ||
| public class Issue35587 : ContentPage | ||
| { | ||
| public Issue35587() | ||
| { | ||
| var radioButton = new RadioButton | ||
| { | ||
| AutomationId = "TestRadioButton", | ||
| Content = "RadioButton", | ||
| }; | ||
|
|
||
| var applyBorderButton = new Button | ||
| { | ||
| AutomationId = "ApplyBorderButton", | ||
| Text = "Apply Border" | ||
| }; | ||
|
|
||
| applyBorderButton.Clicked += (s, e) => | ||
| { | ||
| radioButton.BorderColor = Colors.Green; | ||
| radioButton.BorderWidth = 3; | ||
| }; | ||
|
|
||
| Content = new VerticalStackLayout | ||
| { | ||
| Padding = 20, | ||
| Spacing = 20, | ||
| Children = | ||
| { | ||
| radioButton, | ||
| applyBorderButton | ||
| } | ||
| }; | ||
| } | ||
| } |
25 changes: 25 additions & 0 deletions
25
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue35587.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue35587 : _IssuesUITest | ||
| { | ||
| public Issue35587(TestDevice device) : base(device) { } | ||
|
|
||
| public override string Issue => "RadioButton BorderColor and BorderWidth not applied when dynamically updated at runtime"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.RadioButton)] | ||
| public void RadioButtonBorderAppliedAtRuntime() | ||
| { | ||
| App.WaitForElement("TestRadioButton"); | ||
|
|
||
| // Tap the button to dynamically apply border properties | ||
| App.Tap("ApplyBorderButton"); | ||
|
|
||
| // Verify the border is visually applied | ||
| VerifyScreenshot(); | ||
| } | ||
| } | ||
Binary file added
BIN
+24.1 KB
...s/tests/TestCases.iOS.Tests/snapshots/ios/RadioButtonBorderAppliedAtRuntime.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[major] Regression Prevention — This screenshot assertion is for an issue/fix explicitly affecting Windows as well as Android, but the PR only adds Android and iOS baselines; there is no
TestCases.WinUI.Tests/snapshots/windows/RadioButtonBorderAppliedAtRuntime.png. On WinUI the newVerifyScreenshot()test will either fail for a missing baseline or remain unverified, so the Windows half of the regression is not covered. Please add the WinUI snapshot baseline (or split/skip Windows with an explicit reason).