Recompile agentic-labeler.lock.yml (PR #35540 follow-up)#35549
Merged
Conversation
PR #35540 changed the agentic-labeler.md frontmatter (raised add-labels max from 1 to 10 to stop label truncation) but did not regenerate the compiled lock file. As a result the deployed workflow on main still embedded {"add_labels":{"max":1}} and every labeler run continued to silently drop all but one label. This commit runs 'gh aw compile .github/workflows/agentic-labeler.md' locally to bring the lock file back in sync. The diff is purely the recompile output: - frontmatter_hash updated to match the new .md source - safe-outputs config.json now contains {"add_labels":{"max":10}} - agent system prompt now declares 'add_labels(max:10)' so the orchestrator knows it can return multiple labels in one call - heredoc delimiters rotated as expected for each compile No behaviour changes beyond what PR #35540 already intended. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35549Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35549" |
devanathan-vaithiyanathan
pushed a commit
to devanathan-vaithiyanathan/maui
that referenced
this pull request
Jun 1, 2026
…t#35549) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Description Follow-up to dotnet#35540. That PR fixed the `add-labels` truncation bug by changing the source `.md` from `max: 1` to `max: 10`, but did **not** regenerate the compiled `.lock.yml`. The deployed workflow on `main` therefore still embeds the old config and continues to silently drop all but one label per labeler run. Running `gh aw compile .github/workflows/agentic-labeler.md` locally produces this 17-line diff in the lock file. The substantive changes are: - `frontmatter_hash` updated to match the new `.md` source (so the lock file no longer fails the `ERR_CONFIG: Lock file outdated` check on every dispatch) - safe-outputs `config.json` now emits `{"add_labels":{"max":10}}` (was `{"add_labels":{"max":1}}`) - the agent system prompt now declares `add_labels(max:10)`, so the orchestrator knows it can return multiple labels in one call - heredoc delimiters rotate as expected on every recompile No behaviour changes beyond what dotnet#35540 already intended. This is purely the missing `gh aw compile` output. ## Verification 1. Before this PR: every `gh workflow run agentic-labeler.lock.yml` dispatch fails with `ERR_CONFIG: Lock file ... is outdated! The workflow file ... frontmatter has changed.` (confirmed across 26 attempted backfill dispatches on the affected items in dotnet#35540 audit). 2. With this PR locally, `git diff` shows only the lock file changed; no `.md` modifications. 3. After merge, dispatching the workflow once via `gh workflow run agentic-labeler.lock.yml --repo dotnet/maui --ref main -f issue_number=<N>` against an affected item should now successfully apply multiple `area-*` + `platform/*` labels in a single run (matching dotnet#35540 intent). ## Why this happened PR dotnet#35540 was a documentation-style line-edit on the source `.md` and the author appears to have skipped the mandatory `gh aw compile` step. The repo currently has no CI check that recompiles the lock file and rejects out-of-sync commits — adding such a guard is a separate follow-up. The misleading guidance in `~/.agents/skills/gh-aw-guide` (which contributed to the original `max: 1` bug) is being reviewed in parallel via a multi-model audit — fixes will land in a separate PR against that skill repo. Co-authored-by: bot <bot@test> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description
Follow-up to #35540. That PR fixed the
add-labelstruncation bug by changing the source.mdfrommax: 1tomax: 10, but did not regenerate the compiled.lock.yml. The deployed workflow onmaintherefore still embeds the old config and continues to silently drop all but one label per labeler run.Running
gh aw compile .github/workflows/agentic-labeler.mdlocally produces this 17-line diff in the lock file. The substantive changes are:frontmatter_hashupdated to match the new.mdsource (so the lock file no longer fails theERR_CONFIG: Lock file outdatedcheck on every dispatch)config.jsonnow emits{"add_labels":{"max":10}}(was{"add_labels":{"max":1}})add_labels(max:10), so the orchestrator knows it can return multiple labels in one callNo behaviour changes beyond what #35540 already intended. This is purely the missing
gh aw compileoutput.Verification
gh workflow run agentic-labeler.lock.ymldispatch fails withERR_CONFIG: Lock file ... is outdated! The workflow file ... frontmatter has changed.(confirmed across 26 attempted backfill dispatches on the affected items in Fix agentic-labeler truncating labels to 1 per call #35540 audit).git diffshows only the lock file changed; no.mdmodifications.gh workflow run agentic-labeler.lock.yml --repo dotnet/maui --ref main -f issue_number=<N>against an affected item should now successfully apply multiplearea-*+platform/*labels in a single run (matching Fix agentic-labeler truncating labels to 1 per call #35540 intent).Why this happened
PR #35540 was a documentation-style line-edit on the source
.mdand the author appears to have skipped the mandatorygh aw compilestep. The repo currently has no CI check that recompiles the lock file and rejects out-of-sync commits — adding such a guard is a separate follow-up.The misleading guidance in
~/.agents/skills/gh-aw-guide(which contributed to the originalmax: 1bug) is being reviewed in parallel via a multi-model audit — fixes will land in a separate PR against that skill repo.