Skip to content

Replace JavaFinalize() with Dispose(bool) in GenericAnimatorListener #35548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubaflo merged 4 commits into from
May 21, 2026
Merged

Replace JavaFinalize() with Dispose(bool) in GenericAnimatorListener #35548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
924ad26
Replace JavaFinalize() with Dispose(bool) in GenericAnimatorListener
jonathanpeppers May 20, 2026
a77a53c
Add *REMOVED* entry for JavaFinalize() in PublicAPI.Unshipped.txt
jonathanpeppers May 20, 2026
f5f1370
Add Dispose(bool) entry to PublicAPI.Unshipped.txt
jonathanpeppers May 20, 2026
f1f3238
Merge branch 'inflight/current' into jonathanpeppers/literate-disco
kubaflo May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Controls/src/Core/Platform/Android/GenericAnimatorListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,13 @@ public override void OnAnimationRepeat(Animator animation)
base.OnAnimationRepeat(animation);
}

protected override void JavaFinalize()
protected override void Dispose(bool disposing)
{
OnCancel = OnRepeat = OnEnd = null;
base.JavaFinalize();
if (disposing)
{
OnCancel = OnRepeat = OnEnd = null;
}
base.Dispose(disposing);
}
}
}
2 changes: 2 additions & 0 deletions src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#nullable enable
*REMOVED*override Microsoft.Maui.Controls.Platform.GenericAnimatorListener.JavaFinalize() -> void
override Microsoft.Maui.Controls.Platform.GenericAnimatorListener.Dispose(bool disposing) -> void
override Microsoft.Maui.Controls.GraphicsView.OnBindingContextChanged() -> void
*REMOVED*~static readonly Microsoft.Maui.Controls.Handlers.Compatibility.ShellRenderer.DefaultForegroundColor -> Microsoft.Maui.Graphics.Color
*REMOVED*~static readonly Microsoft.Maui.Controls.Handlers.Compatibility.ShellRenderer.DefaultTitleColor -> Microsoft.Maui.Graphics.Color
Expand Down
Loading