-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix Android MediaPicker result recovery #35455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AdamEssenmacher
wants to merge
17
commits into
dotnet:net11.0
Choose a base branch
from
AdamEssenmacher:35308
base: net11.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d788f41
Fix Android MediaPicker result recovery
AdamEssenmacher 0159a3a
Fix MediaPicker recovery rotation test
AdamEssenmacher 5e56961
Avoid materializing picker results in callbacks
AdamEssenmacher d197896
Add diagnostics for AndroidX activity result state key
AdamEssenmacher 0ccc432
Add MediaPicker pending operation discard API
AdamEssenmacher 86f87bb
Persist picker URI access before recovery state
AdamEssenmacher f05d84c
Document plural picker callback matching
AdamEssenmacher 7eade57
Observe orphaned MediaPicker recovery tasks
AdamEssenmacher fe41ef0
Simplify MediaPicker recovery serialization
AdamEssenmacher 7dabf2f
Fix MediaPicker recovery waiter registration race
AdamEssenmacher df8a51d
Fix persistable picker URI grant leaks
AdamEssenmacher 2327791
Fix MediaPicker recovery begin race
AdamEssenmacher 78b1c1e
Bound recovered MediaPicker records
AdamEssenmacher 39a8529
Require cancellable MediaPicker recovery waits
AdamEssenmacher 6acd98f
Delete rotated MediaPicker recovery temp file
AdamEssenmacher cb5c4bb
Add content URI MediaPicker recovery test
AdamEssenmacher a38f919
Address MediaPicker recovery review feedback
AdamEssenmacher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
src/Core/tests/DeviceTests/Platform/AndroidXActivityResultRegistryTests.Android.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| using AndroidX.Activity; | ||
| using Xunit; | ||
| using JavaClass = Java.Lang.Class; | ||
|
|
||
| namespace Microsoft.Maui.DeviceTests | ||
| { | ||
| [Category(TestCategory.Application)] | ||
| public class AndroidXActivityResultRegistryTests | ||
| { | ||
| const string ExpectedActivityResultRegistryKey = "android:support:activity-result"; | ||
|
|
||
| [Fact] | ||
| public void ComponentActivity_ActivityResultSavedStateKey_MatchesMauiRecoveryKey() | ||
| { | ||
| using var componentActivityClass = JavaClass.FromType(typeof(ComponentActivity)); | ||
| using var activityResultTagField = componentActivityClass.GetDeclaredField("ACTIVITY_RESULT_TAG"); | ||
| activityResultTagField.Accessible = true; | ||
|
|
||
| var activityResultTag = activityResultTagField.Get(null)?.ToString(); | ||
|
|
||
| Assert.Equal(ExpectedActivityResultRegistryKey, activityResultTag); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.