Skip to content

[Testing] Replace retryDelay with retryTimeout in UI tests #35367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubaflo merged 1 commit into from
May 10, 2026
Merged

[Testing] Replace retryDelay with retryTimeout in UI tests #35367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18751.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ public Issue18751(TestDevice device) : base(device)
public void Issue18751Test()
{
App.WaitForElement("WaitForStubControl");
// Load images and hide scrollbar.
// The test passes if you are able to see the image, name, and location of each monkey.
VerifyScreenshot(retryDelay: TimeSpan.FromSeconds(2));
// CollectionView uses virtualization which loads images synchronously once items are visible.
// Use retryTimeout to adaptively wait for any timing variance.
VerifyScreenshot(retryTimeout: TimeSpan.FromSeconds(2));
}
}
7 changes: 4 additions & 3 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18896.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ public void Issue18896Test()
#else
App.ScrollUp(ListView);
#endif
// Load images and hide scrollbar.
// The test passes if you are able to see the image, name, and location of each monkey.
VerifyScreenshot(retryDelay: TimeSpan.FromSeconds(2));
// ListView with HasUnevenRows may have variable height row rendering that requires
// additional time for images to load and scrollbar to disappear.
// Use retryTimeout to adaptively wait for the UI to stabilize.
VerifyScreenshot(retryTimeout: TimeSpan.FromSeconds(3));
}
}
Loading