Revert "[Android, iOS] Throw exceptions consistently for invalid StaticResource references to prevent relaunch crashes (#33859)"

[PureWeen]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description

Reverts #33859 on the release/10.0.1xx-sr6 branch due to a regression.

This change introduced consistent exception throwing for invalid StaticResource references, but it is causing regressions in production scenarios.

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35130

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35130"

[Copilot]

Pull request overview

Reverts the behavior introduced in #33859 on release/10.0.1xx-sr6, restoring prior handling for invalid {StaticResource ...} lookups to avoid production regressions.

Changes:

• Restore {StaticResource} behavior to return null (after invoking ResourceLoader.ExceptionHandler2) instead of always throwing.
• Remove the ApplyPropertiesVisitor special-case that forced StaticResourceExtension to rethrow even when an exception handler is present.
• Update/remove tests that were asserting the “always throw” behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
src/Controls/tests/Xaml.UnitTests/HotReloadStaticResourceException.xaml.cs	Updates the debug/hot reload unit test to validate handler invocation without expecting a thrown exception.
src/Controls/tests/DeviceTests/Xaml/StaticResourceTests.cs	Removes the device test that asserted missing StaticResource always throws with an exception handler present.
src/Controls/src/Xaml/MarkupExtensions/StaticResourceExtension.cs	Restores prior behavior: invoke ExceptionHandler2 (with file path) and return null; otherwise throw XamlParseException.
src/Controls/src/Xaml/ApplyPropertiesVisitor.cs	Removes the forced-rethrow path for StaticResourceExtension, returning to generic exception-handler behavior.

Comments suppressed due to low confidence (1)

src/Controls/src/Xaml/ApplyPropertiesVisitor.cs:287

• In this catch block, throw e; resets the exception stack trace to this location. With the StaticResourceExtension special-casing removed above, missing StaticResource exceptions will now typically be rethrown via this path (when Context.ExceptionHandler is null), which makes diagnosing the original XAML failure harder. Please rethrow while preserving the original stack trace (e.g., use a bare throw; here).

			{
				if (Context.ExceptionHandler != null)
					Context.ExceptionHandler(e);
				else
					throw e;