Skip to content
Merged
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b1e2df1
Add CI investigation guidance: always use ci-analysis skill
github-actions[bot] Apr 23, 2026
5a4b6f0
Remove pr-finalize changes — keep CI guidance in copilot-instructions…
github-actions[bot] Apr 23, 2026
25e1a80
Address review: XHarness caveat, skill escalation, accurate claims
github-actions[bot] Apr 23, 2026
115d1fd
Add guidance: verify test execution from CI results, not code
github-actions[bot] Apr 27, 2026
1b8ca97
Fix: resolve internal contradiction in CI guidance wording
PureWeen Apr 27, 2026
9ff1363
Fix review findings: scoping, label context, skill routing
PureWeen Apr 27, 2026
71eb5af
Fix: pr-build-status dead reference, clarify test API usage
PureWeen Apr 27, 2026
7b2a0f9
Remove phantom pr-build-status skill entry
PureWeen Apr 27, 2026
f35da54
Simplify device test caveat: remove inline gh pr view instruction
PureWeen Apr 27, 2026
bcdb797
Simplify CI guidance: use azdo-build-investigator as primary skill
PureWeen Apr 27, 2026
6787a3f
Add guidance for triggering CI on community PRs
PureWeen Apr 27, 2026
ebeeb36
Add test count deduplication guidance to azdo-build-investigator
PureWeen Apr 28, 2026
b397906
Refine test dedup: group by test name + platform, not just name
PureWeen Apr 28, 2026
75f67b8
Fix: clarify skill invocation model, specify dedup grouping key
PureWeen Apr 28, 2026
0977c16
Add eval tests for azdo-build-investigator skill
PureWeen Apr 28, 2026
edfec60
Fix eval scenarios: stable PRs, remove non-activation tests
PureWeen Apr 28, 2026
393bbb0
Replace no-builds scenario with failure classification scenario
PureWeen Apr 29, 2026
b759724
Move operational CI details from copilot-instructions to skill
PureWeen Apr 29, 2026
f7b3ff5
Merge main: resolve conflicts, keep both CI guidance and Gradle docs
PureWeen Apr 29, 2026
50756c7
Remove eval tests for azdo-build-investigator
PureWeen Apr 30, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/copilot-instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,24 @@ When referencing or triggering CI pipelines, use these current pipeline names:

**⚠️ Old pipeline names** (e.g., `MAUI-UITests-public`, `MAUI-public`) are **outdated** and should NOT be used. Always use the names above.

### Investigating CI Failures

**🚨 ALWAYS use the `ci-analysis` skill when investigating CI failures or assessing merge readiness.** Do NOT manually query AzDO APIs or rely solely on `gh pr checks` pass/fail counts.

Copilot AI Apr 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description claims updates to .github/skills/pr-finalize/SKILL.md (new CI verification phase / renumbering), but this PR diff only shows changes to .github/copilot-instructions.md. Either include the pr-finalize changes in this PR or update the PR description so it matches what’s actually being changed.

Copilot uses AI. Check for mistakes.

The `ci-analysis` skill provides:
- **Helix log retrieval** — downloads and parses actual test failure messages from Helix work items
- **Known issue matching** — automatically correlates failures against `Known Build Error` labeled issues
- **Cross-build aggregation** — analyzes all pipeline runs (maui-pr, maui-pr-uitests, maui-pr-devicetests) in one pass
- **Test result details** — reports actual failing test names and error messages, not just job-level pass/fail

Copilot AI Apr 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section mandates ci-analysis, but it doesn’t explain that ci-analysis is provided via the dotnet/arcade-skills plugin (enabled in .github/copilot/settings.json) rather than a skill under .github/skills/. Consider adding a short note on how/where it’s loaded and cross-referencing the repo’s MAUI-specific CI guidance (azdo-build-investigator skill). Also, since you’re introducing a new required skill here, the later “User-Facing Skills” list should mention ci-analysis (and should not reference non-existent skills like pr-build-status).

Copilot uses AI. Check for mistakes.

**When to use it:**
- "How does CI look?" / "Is CI green?" / "Can we merge?"
- "What's failing?" / "Are these known failures?"
- "Is this PR safe to merge?" / "Any CI concerns?"
- After any PR push to verify the build

**Anti-pattern:** Manually running `curl` against AzDO APIs and `python3` scripts to parse timelines. This misses Helix work item details, doesn't cross-reference known issues, and doesn't aggregate test results across runs — leading to incomplete or incorrect CI assessments.

### Code Formatting

Always format code before committing:
Expand Down
Loading