Skip to content

Fix CI failure for CollectionView and CarouselView tests in April 14th Candidate #35028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubaflo merged 2 commits into from
Apr 18, 2026
Merged

Fix CI failure for CollectionView and CarouselView tests in April 14th Candidate #35028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20cd0a0
fix added
devanathan-vaithiyanathan Apr 17, 2026
d306ae6
Update Issue22417.xaml
devanathan-vaithiyanathan Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Controls/src/Core/Items/MarshalingObservableCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public class MarshalingObservableCollection : List<object>, INotifyCollectionCha
readonly IList _internalCollection;
readonly IDispatcher _dispatcher;
readonly WeakNotifyCollectionChangedProxy _proxy;
readonly NotifyCollectionChangedEventHandler _internalCollectionChanged;

/// <param name="list">The list parameter.</param>
public MarshalingObservableCollection(IList list)
Expand All @@ -33,7 +34,8 @@ public MarshalingObservableCollection(IList list)

_internalCollection = list;
_dispatcher = Dispatcher.GetForCurrentThread();
_proxy = new WeakNotifyCollectionChangedProxy(incc, InternalCollectionChanged);
_internalCollectionChanged = InternalCollectionChanged;
_proxy = new WeakNotifyCollectionChangedProxy(incc, _internalCollectionChanged);

foreach (var item in _internalCollection)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Controls/tests/TestCases.HostApp/Issues/Issue22417.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
x:Name="TestCarouselView"
Grid.Row="1"
ItemTemplate="{StaticResource SampleItemTemplate}"
Loop="True"
Loop="False"
HeightRequest="250"
HorizontalOptions="Center"/>

Expand Down
Loading