[Testing] Fixed test failure in PR 34885 - [04/14/2026] Candidate#34959
Merged
kubaflo merged 23 commits intoApr 20, 2026
Conversation
dotnet-policy-service
Bot
added
community ✨
Contributor
|
/azp run maui-pr-uitests , maui-pr-devicetests |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Apr 14, 2026
Open
Contributor
|
/azp run maui-pr-uitests , maui-pr-devicetests |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Apr 15, 2026
Contributor
|
/azp run maui-pr-uitests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run maui-pr-uitests , maui-pr-devicetests |
|
Azure Pipelines successfully started running 2 pipeline(s). |
TamilarasanSF4853
force-pushed
the
candidate-fix-34885-1
branch
from
02f5c6c to
7461c3d
Compare
Contributor
|
/azp run maui-pr-uitests , maui-pr-devicetests |
|
Azure Pipelines successfully started running 2 pipeline(s). |
3 tasks
PureWeen
pushed a commit
that referenced
this pull request
Apr 21, 2026
Two fixes to milestone detection:
1. Fallback reads Versions.props from the development branch (main
for .NET 10, net11.0 for .NET 11) instead of origin/{base.ref}.
Staging branches like inflight/candidate have stale PatchVersion
but their PRs ultimately ship on main's version.
2. Find-ReleaseBranchForCommit falls back to git log --grep when
ancestry check fails. Handles rebases and cherry-picks where the
commit SHA changes but the PR number '(#NNNNN)' is preserved in
the commit message.
Updated live validation guide to match new behavior.
Validated:
- #34667 (rebased to SR6) → found via grep → .NET 10 SR6 ✅
- #34959 (inflight/candidate) → reads main → .NET 10 SR7 ✅
- #34620 (on SR6 branch) → ancestry → .NET 10 SR6 ✅
- #34969 (net11.0) → reads net11.0 → .NET 11.0-preview4 ✅
91 Pester tests pass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 21, 2026
…ng branch (#35054) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Summary Fix milestone fallback for `inflight/*` and `darc/*` branches to read from `origin/main` instead of the staging branch itself. ## Problem PRs merged to `inflight/candidate` were milestoned as SR6 because `inflight/candidate` has `PatchVersion=60`. But those PRs will ultimately ship in SR7 (when the Candidate merges to `main`, which is at `PatchVersion=70`). ## Fix For staging branches (`inflight/*`, `darc/*`), read `Versions.props` from `origin/main` instead of `origin/{base.ref}`. These branches always feed into main, so main's version is the correct target. All other branches continue reading from `origin/{base.ref}` directly. ## Validated | PR | Base | Before | After | |---|---|---|---| | #34959 | inflight/candidate | SR6 (wrong) | SR7 ✅ | | #35040 | inflight/current | SR7 | SR7 ✅ | | #34969 | net11.0 | preview1 | preview4 ✅ | | #34620 | main (on SR6 branch) | SR6 | SR6 ✅ | 91 Pester tests pass. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ahamed-Ali
pushed a commit
that referenced
this pull request
Apr 22, 2026
…4959) This pull request updates test cases for carousel and label tap behavior to improve reliability and accuracy. The main changes include improving tap detection in label tests, updating the carousel view bounce test to use a new button for navigation, and adding a new UI element to the carousel view test page. **Test improvements:** * In the label tap test (`Issue21837.cs`), taps are now performed at specific coordinates near the leading edge of each label's text to ensure accurate hit detection, especially when label widths exceed the rendered text width. **Carousel view test updates:** * The carousel bounce test (`Issue29261.cs`) now uses a newly added "Go to Last" button to reliably set the carousel to the last position before testing bounce behavior, replacing multiple swipe actions with a button tap and scroll gestures. * The test page for the carousel view (`Issue29261.cs`) adds a "Go to Last" button (`goToLastButton`) to facilitate direct navigation to the last carousel item. **Test cleanup:** * Removes unnecessary conditional compilation and comments related to unsupported swipe actions on Catalyst, simplifying test code. **Test image resaving:** * Resaved the valid images on the Android, iOS and macOS platforms **Fixes:** #34885 --------- Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com> Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com> Co-authored-by: Subhiksha Chandrasekaran <subhiksha.c@syncfusion.com> Co-authored-by: LogishaSelvarajSF4525 <logisha.selvaraj@syncfusion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates test cases for carousel and label tap behavior to improve reliability and accuracy. The main changes include improving tap detection in label tests, updating the carousel view bounce test to use a new button for navigation, and adding a new UI element to the carousel view test page.
Test improvements:
Issue21837.cs), taps are now performed at specific coordinates near the leading edge of each label's text to ensure accurate hit detection, especially when label widths exceed the rendered text width.Carousel view test updates:
Issue29261.cs) now uses a newly added "Go to Last" button to reliably set the carousel to the last position before testing bounce behavior, replacing multiple swipe actions with a button tap and scroll gestures.Issue29261.cs) adds a "Go to Last" button (goToLastButton) to facilitate direct navigation to the last carousel item.Test cleanup:
Test image resaving:
Fixes: #34885