Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Windows] Lifecycle: Add AppInstance activated event #34883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
[Windows] Lifecycle: Add AppInstance activated event #34883
Changes from 1 commit
14d323369050ebec30eb1e4b684fb27df668ab84a6c1554db60a221f144023aFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[major] Async and Threading Safety — Same blocking pattern as the library code:
keyInstance.RedirectActivationToAsync(args).AsTask().GetAwaiter().GetResult()runs insideHandleWindowsAppInstanceActivated, invoked as aWindowsLifecycle.OnAppInstanceActivatedhandler on the UI thread (either directly fromOnLaunchedor dispatched fromMauiWinUIApplication.HandleAppInstanceActivated). This is presented to app authors as recommended single-instancing boilerplate, but it teaches the same deadlock/hang-prone anti-pattern flagged in the product code instead ofawaiting the redirect.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description and metadata refer to a new
OnAppActivation(...)hook, but the implementation introducesOnAppInstanceActivated(...)instead. Please update the PR description (or rename the API) so the documented public surface matches the code that will ship.Uh oh!
There was an error while loading. Please reload this page.