-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix [Android] Title of FlyOutPage is not updating anymore after showing a NonFlyOutPage #34839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kubaflo
merged 5 commits into
dotnet:inflight/current
from
KarthikRajaKalaimani:fix-33615
Apr 16, 2026
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f39206d
Test case and fix included
KarthikRajaKalaimani 04cf2ee
Android snap included
KarthikRajaKalaimani 9dee3f8
Windows and iOS 26 snapshots included
KarthikRajaKalaimani 5d83a3d
Fix improved
KarthikRajaKalaimani e0fb74a
Snapshot added for winui and mac platforms
KarthikRajaKalaimani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+21.7 KB
...Cases.Android.Tests/snapshots/android/TitleUpdatesAfterShowingNonFlyoutPage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 33615, "[Android] Title of FlyOutPage is not updating anymore after showing a NonFlyOutPage", PlatformAffected.Android)] | ||
| public class Issue33615 : TestFlyoutPage | ||
| { | ||
| NavigationPage _navigationPage; | ||
|
|
||
| protected override void Init() | ||
| { | ||
| Flyout = new ContentPage | ||
| { | ||
| Title = "Menu", | ||
| Content = new Label { Text = "Flyout Menu" } | ||
| }; | ||
|
|
||
| var detailPage1 = new ContentPage { Title = "DetailPage1" }; | ||
| _navigationPage = new NavigationPage(detailPage1); | ||
| Detail = _navigationPage; | ||
|
|
||
| detailPage1.Content = new VerticalStackLayout | ||
| { | ||
| VerticalOptions = LayoutOptions.Center, | ||
| Children = | ||
| { | ||
| new Button | ||
| { | ||
| Text = "Show NonFlyoutPage", | ||
| AutomationId = "ShowNonFlyoutButton", | ||
| Command = new Command(() => | ||
| { | ||
| this.Window.Page = new Issue33615NonFlyoutPage(this); | ||
| }) | ||
| }, | ||
| new Button | ||
| { | ||
| Text = "Navigate to DetailPage2", | ||
| AutomationId = "NavigateToDetailPage2Button", | ||
| Command = new Command(async () => | ||
| { | ||
| await _navigationPage.PushAsync(new ContentPage | ||
| { | ||
| Title = "DetailPage2", | ||
| Content = new Label | ||
| { | ||
| Text = "DetailPage2", | ||
| AutomationId = "DetailPage2Label" | ||
| } | ||
| }); | ||
| }) | ||
| }, | ||
| new Label | ||
| { | ||
| Text = "DetailPage1", | ||
| AutomationId = "DetailPage1Label" | ||
| } | ||
| } | ||
| }; | ||
| } | ||
| } | ||
|
|
||
| class Issue33615NonFlyoutPage : ContentPage | ||
| { | ||
| public Issue33615NonFlyoutPage(Page flyoutPage) | ||
| { | ||
| Title = "NonFlyoutPage"; | ||
| Content = new VerticalStackLayout | ||
| { | ||
| VerticalOptions = LayoutOptions.Center, | ||
| Children = | ||
| { | ||
| new Label { Text = "NonFlyoutPage" }, | ||
| new Button | ||
| { | ||
| Text = "Back to FlyoutPage", | ||
| AutomationId = "BackToFlyoutButton", | ||
| Command = new Command(() => this.Window.Page = flyoutPage) | ||
| } | ||
| } | ||
| }; | ||
| } | ||
| } |
42 changes: 42 additions & 0 deletions
42
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33615.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue33615 : _IssuesUITest | ||
| { | ||
| public Issue33615(TestDevice device) : base(device) { } | ||
|
|
||
| public override string Issue => "[Android] Title of FlyOutPage is not updating anymore after showing a NonFlyOutPage"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.FlyoutPage)] | ||
| public void TitleUpdatesAfterShowingNonFlyoutPage() | ||
| { | ||
| // Wait for the FlyoutPage detail (DetailPage1) to load | ||
| App.WaitForElement("ShowNonFlyoutButton"); | ||
|
|
||
| // Show a NonFlyoutPage by changing Window.Page | ||
| App.Tap("ShowNonFlyoutButton"); | ||
|
|
||
| // Wait for the NonFlyoutPage to appear | ||
| App.WaitForElement("BackToFlyoutButton"); | ||
|
|
||
| // Go back to the FlyoutPage | ||
| App.Tap("BackToFlyoutButton"); | ||
|
|
||
| // Wait for the FlyoutPage to be restored with DetailPage1 | ||
| App.WaitForElement("NavigateToDetailPage2Button"); | ||
|
|
||
| // Navigate to DetailPage2 — the toolbar title should update to "DetailPage2" | ||
| App.Tap("NavigateToDetailPage2Button"); | ||
|
|
||
| // Verify DetailPage2 is the current page | ||
| App.WaitForElement("DetailPage2Label"); | ||
|
|
||
| // The toolbar title must match "DetailPage2" — use VerifyScreenshot to | ||
| // detect if the toolbar is frozen on the old title "DetailPage1" | ||
| VerifyScreenshot(); | ||
| } | ||
|
KarthikRajaKalaimani marked this conversation as resolved.
|
||
| } | ||
Binary file added
BIN
+14.3 KB
...stCases.WinUI.Tests/snapshots/windows/TitleUpdatesAfterShowingNonFlyoutPage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+68.3 KB
.../TestCases.iOS.Tests/snapshots/ios-26/TitleUpdatesAfterShowingNonFlyoutPage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+28.7 KB
...sts/TestCases.iOS.Tests/snapshots/ios/TitleUpdatesAfterShowingNonFlyoutPage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.