-
Notifications
You must be signed in to change notification settings - Fork 2k
[iOS] Fix ArgumentOutOfRangeException in ObservableGroupedSource when removing a group from grouped CollectionView #34692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
baaaaif
wants to merge
6
commits into
dotnet:main
from
baaaaif:fix/observable-grouped-source-remove-crash
+137
−2
Closed
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1db8c3b
fix: prevent ArgumentOutOfRangeException in ObservableGroupedSource w…
baaaaif de54a54
test: add regression tests for grouped CollectionView section removal…
baaaaif ea354b4
test: improve regression tests for grouped CollectionView section rem…
baaaaif 4d933de
test: fix build errors in grouped CollectionView regression tests
baaaaif a7a523a
Improve test assertions and trim verbose comments
Copilot 1f00297
Fix test build: use Controller.CollectionView for NumberOfSections
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[major] Regression Prevention — This removes the backing group before verifying that the native UICollectionView has realized the original sections. If
uiCollectionView.NumberOfSections()is still 0,ObservableGroupedSource.Removetakes theReloadRequired()path and the test passes without exercising the stale-sectionDeleteSections/GetGroupCountpath that caused the crash. Please force layout and assert the precondition (NumberOfSections() == groupData.Count) before each removal; the same issue applies to the removals at lines 120 and 161.