Fix CI pipeline build warnings (RS0016/RS0017, XA1006, duplicate splash, XAML)

[rmarinho]

Description

Fixes ~97 build warnings that appear on every PR pipeline run (visible in the CI build logs for Build Microsoft.Maui.sln steps).

Changes

• RS0016/RS0017 (81 warnings): PublicAPI.Unshipped.txt entries in Essentials.AI were missing the [MAUIAI0001] prefix required by the assembly-level [Experimental("MAUIAI0001")] attribute. Added prefix to all entries in net-ios, net-maccatalyst, net-macos.
• Duplicate MauiSplashScreen (6 warnings): Essentials.AI.Sample.csproj had two MauiSplashScreen entries (same SVG, different colors). Removed duplicate.
• XA1006/XA4211 (4 warnings): GraphicsTester.Android AndroidManifest.xml had targetSdkVersion=31 but TFM targets API 36. Updated to 36.
• XAML property element (6 warnings): TwoPaneViewPage.xaml had BackgroundColor attribute on property element Pane1 (invalid, ignored at runtime). Moved to child Frame.

Not addressed (intentional/external)

• XC0022/XC0023/XC0045/XC0618/MAUIG2045 (125 warnings) - Intentional in Controls.Xaml.UnitTests test project (configured via WarningsNotAsErrors)
• MSB3021/3026/3027 - Transient file-locking during parallel CI builds
• XA0141 - Third-party NuGet (Gee.External.Capstone) 16KB page alignment warning in benchmarks

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34629

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34629"

[Copilot]

Pull request overview

Reduces recurring CI build warnings across MAUI solution builds by aligning platform metadata (Android manifest), fixing invalid XAML, and correcting PublicAPI analyzer expectations for an experimental assembly.

Changes:

• Add the [MAUIAI0001] experimental diagnostic prefix to Essentials.AI PublicAPI unshipped entries for Apple TFMs to resolve RS0016/RS0017 warnings.
• Update GraphicsTester.Android manifest targetSdkVersion to match the repo’s current default Android API level and eliminate XA1006/XA4211 warnings.
• Fix invalid XAML usage in TwoPaneViewPage.xaml and remove a duplicate splash screen item from the Essentials.AI sample project.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/Graphics/samples/GraphicsTester.Android/Properties/AndroidManifest.xml	Updates targetSdkVersion to match current Android API level and stop related Android build warnings.
src/Controls/samples/Controls.Sample/Pages/Others/TwoPaneViewPage.xaml	Corrects invalid property-element attribute usage by moving BackgroundColor to a valid element.
src/AI/src/Essentials.AI/PublicAPI/net-macos/PublicAPI.Unshipped.txt	Prefixes unshipped APIs with the experimental diagnostic ID to satisfy PublicAPI analyzers.
src/AI/src/Essentials.AI/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt	Same experimental prefix fix for MacCatalyst PublicAPI entries.
src/AI/src/Essentials.AI/PublicAPI/net-ios/PublicAPI.Unshipped.txt	Same experimental prefix fix for iOS PublicAPI entries.
src/AI/samples/Essentials.AI.Sample/Essentials.AI.Sample.csproj	Removes a duplicate MauiSplashScreen item that was causing warnings.

[kubaflo]

/review -b feature/refactor-copilot-yml

[kubaflo]

Could you please resolve conflicts?

[kubaflo]

/review -b feature/enhanced-reviewer -p android

[kubaflo]

🔍 AI-generated — automated conflict resolution & review by GitHub Copilot CLI, on behalf of @kubaflo. Please verify before merging.

Conflict resolved (merge main)

The conflicts were the 3 Essentials.AI PublicAPI.Unshipped.txt files (net‑ios/maccatalyst/macos).

● These RS0016/RS0017 entries are now obsolete: main has since shipped those AppleIntelligence/NLEmbedding APIs (moved to PublicAPI.Shipped.txt), so Unshipped is now empty on main. Re‑adding them would create duplicate‑API analyzer errors — exactly the kind of warning this PR targets — so I took main's empty Unshipped.

Remaining (still valid) warning fixes in this PR

• AndroidManifest.xml: targetSdkVersion 31 → 36 (XA1006)
• TwoPaneViewPage.xaml: moved BackgroundColor to the inner Frame
• Removed duplicate MauiSplashScreen in Essentials.AI.Sample.csproj

The PR is smaller now (the PublicAPI portion collapsed to a no‑op), but the remaining warning fixes are still worthwhile.

[MauiBot]

AI Review Summary

@rmarinho — new AI review results are available based on this last commit: e989469. To request a fresh review after new comments or commits, comment /review rerun.

---

🗂️ Review Sessions — click to expand

🚦 Gate — Test Before & After Fix

Gate Result: ⚠️ INCONCLUSIVE

Platform: ANDROID

⚠️ verify-tests-fail.ps1 exited before writing a verification report. Diagnostics below.

Exit code: 3

Likely cause:

• Test detection failed — no runnable tests were found in the PR diff.

Gate output log (last 60 lines)

📁 Output directory: CustomAgentLogsTmp/PRState/34629/PRAgent/gate/verify-tests-fail
🔍 Detecting base branch and merge point...
No PR detected, scanning remote branches for closest base...
✅ Base branch: main (via closest-merge-base)
✅ Merge base commit: 6b9166ad
   (1 commits ahead of main)
╔═══════════════════════════════════════════════════════════╗
║         FULL VERIFICATION MODE                            ║
╠═══════════════════════════════════════════════════════════╣
║  Fix files detected - will verify:                        ║
║  1. Tests FAIL without fix                                ║
║  2. Tests PASS with fix                                   ║
╚═══════════════════════════════════════════════════════════╝
✅ Fix files (3):
   - src/AI/samples/Essentials.AI.Sample/Essentials.AI.Sample.csproj
   - src/Controls/samples/Controls.Sample/Pages/Others/TwoPaneViewPage.xaml
   - src/Graphics/samples/GraphicsTester.Android/Properties/AndroidManifest.xml
🔍 Auto-detecting test filter from changed test files...
⚠️ No tests detected in this PR.
   Searched for: UI tests, unit tests, XAML tests, device tests
   Consider adding tests via write-tests-agent.

---

📋 Pre-Flight — Context & Validation

Issue: #34629 - Fix CI pipeline build warnings (RS0016/RS0017, XA1006, duplicate splash, XAML)
PR: #34629 - Fix CI pipeline build warnings (RS0016/RS0017, XA1006, duplicate splash, XAML)
Platforms Affected: Android; sample XAML; sample project resources
Files Changed: 3 implementation/sample files, 0 test files

Key Findings

• The final PR diff is smaller than the description: PublicAPI.Unshipped changes were absorbed by conflict resolution because the APIs are already shipped on main.
• The remaining code changes remove a duplicate splash screen item, fix an invalid XAML property-element attribute, and update the GraphicsTester Android target SDK.
• Gate was supplied as inconclusive because no runnable tests were detected; no gate rerun was performed.
• Existing regression-check output says no implementation files were modified, so no framework regression cross-reference was required.

Code Review Summary

Verdict: NEEDS_DISCUSSION
Confidence: low
Errors: 0 | Warnings: 1 | Suggestions: 1

Key code review findings:

• ⚠ PR description is stale for the RS0016/RS0017 PublicAPI section because those changes are no longer in the final diff.
• ℹ The XAML background-color move is valid but visibly changes the sample because the old property-element attribute was ignored.

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #34629	Remove duplicate splash entry; move invalid Pane1 background to Frame; hardcode targetSdkVersion=36 in GraphicsTester.Android manifest.	⚠ INCONCLUSIVE (Gate)	Essentials.AI.Sample.csproj, TwoPaneViewPage.xaml, AndroidManifest.xml	Original PR. Gate did not find runnable tests.

---

🔬 Code Review — Deep Analysis

Code Review — PR #34629

Independent Assessment

What this changes: Three sample/tooling files are modified: Essentials.AI.Sample.csproj removes a duplicate MauiSplashScreen, TwoPaneViewPage.xaml moves an invalid BackgroundColor attribute from the TwoPaneView.Pane1 property element to the child Frame, and GraphicsTester.Android/AndroidManifest.xml bumps android:targetSdkVersion from 31 to 36.

Inferred motivation: Reduce recurring build warnings in CI without touching production framework code.

Reconciliation with PR Narrative

Author claims: The PR description says it fixes RS0016/RS0017 PublicAPI warnings, duplicate splash warnings, Android XA1006/XA4211 target SDK warnings, and XAML property-element warnings.

Agreement/disagreement: The final diff matches the duplicate splash, Android manifest, and XAML warning fixes. The RS0016/RS0017 portion is now stale after conflict resolution: those Essentials.AI entries were already moved to PublicAPI.Shipped.txt on main, so the final diff no longer contains PublicAPI changes.

Prior Review Reconciliation

Prior Error Finding	Source	Status	Evidence
Resolve merge conflicts	MauiBot / prior review comments	Fixed	Public GitHub API reports the PR is currently mergeable; the latest comment explains that the PublicAPI conflict was resolved by taking main's empty Unshipped files.

No unresolved prior error-level code findings were found.

Blast Radius Assessment

Not required for handler/platform framework code. The changed files are sample/tooling files only and do not affect production handlers, layout code, startup infrastructure, or shared static state.

CI Status

• Required-check result: undetermined locally.
• Classification: tool-unavailable / pending context. gh is unauthenticated in this environment, and the caller supplied Gate result is inconclusive because no runnable tests were detected.
• Action taken: confidence capped; no LGTM based solely on local review.

Findings

Warning — PR description is stale for RS0016/RS0017

The PR description still describes PublicAPI.Unshipped changes that are no longer present in the final diff. This is a documentation/reviewability issue, not a code correctness error.

Suggestion — Call out the visible XAML behavior change

Moving BackgroundColor="#dddddd" to Frame makes the color effective; the old property-element attribute was invalid/ignored. This is intended, but it is worth making explicit in the PR description.

Failure-Mode Probing

• Android target SDK bump: limited to GraphicsTester.Android, a sample app. It can only affect that sample's Android build/runtime behavior.
• Duplicate splash removal: remaining entry uses the standard MAUI purple color; removing the dark duplicate eliminates ambiguous duplicate item processing.
• XAML BackgroundColor relocation: Frame supports BackgroundColor; moving the invalid attribute to a real element is semantically valid and localized to the sample page.
• PublicAPI conflict resolution: no final PublicAPI diff remains, so PublicAPI analyzers should not see duplicate unshipped/shipped API entries from this PR.

Verdict: NEEDS_DISCUSSION

Confidence: low

Summary: No code correctness errors were found in the PR's remaining sample/tooling changes. Confidence remains low because CI/gate evidence is inconclusive in this environment and the PR description is stale relative to the final diff.

---

🛠️ Fix — Analysis & Comparison

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
1	try-fix	Remove <uses-sdk> entirely and move pane background to TwoPaneView.	⚠ BLOCKED	2 files	Local workload resolution continued reporting NETSDK1147 after one restore attempt; approach also risked generated min SDK drift.
2	try-fix	Move targetSdkVersion to <TargetPlatformVersion>36.0</TargetPlatformVersion> while keeping manifest minSdkVersion=23.	❌ FAIL	2 files	Failed with XA1036 because evaluated Android SupportedOSPlatformVersion is 21.0 while manifest min SDK is 23.
3	try-fix	Guard repo Android SupportedOSPlatformVersion, add project TargetPlatformVersion=36.0, and remove source <uses-sdk>.	❌ FAIL	3 files	Avoided XA1036 but failed restore/build due net10.0-android36.0 asset target mismatches in project references.
PR	PR #34629	Remove duplicate splash entry; move invalid Pane1 background to Frame; hardcode targetSdkVersion=36 in GraphicsTester.Android manifest.	⚠ INCONCLUSIVE (Gate)	3 files	Local review found no code correctness errors; gate found no runnable tests.

Cross-Pollination

Model	Round	New Ideas?	Details
maui-expert-reviewer	1	Yes	Candidate 1: SDK-derived manifest and TwoPaneView-level background.
maui-expert-reviewer	2	Yes	Candidate 2: project TargetPlatformVersion, keep manifest min SDK.
maui-expert-reviewer	3	Yes	Candidate 3: guard repo Android default and make MSBuild the single source of truth.
maui-expert-reviewer	4	No	Remaining variants collapse into either the PR's localized hardcoded manifest fix or broader MSBuild/TFM changes that failed validation.

Exhausted: Yes
Selected Fix: PR's fix — It is the only localized approach that avoids the empirically observed XA1036 and project-reference asset graph failures. No alternative candidate passed all focused validation or was demonstrably better than the PR.

---

📝 Recommended PR Title & Description

Assessment: ✏️ Recommend updating — the current title and description still claim RS0016/RS0017 PublicAPI changes that are no longer present in the final diff.

Recommended title

[Android/Samples] Fix target SDK, duplicate splash, and TwoPaneView XAML warnings

Recommended description

## Description

Fixes recurring build warnings from sample/tooling files that appear in PR pipeline build logs.

### Changes

- **Duplicate MauiSplashScreen (6 warnings)**: `Essentials.AI.Sample.csproj` had two `MauiSplashScreen` entries for the same SVG with different colors. Removed the duplicate and kept the standard `#512BD4` entry.
- **XA1006/XA4211 (4 warnings)**: `GraphicsTester.Android` `AndroidManifest.xml` had `targetSdkVersion=31` while the Android TFM targets API 36. Updated the manifest target SDK to 36 while preserving `minSdkVersion=23`.
- **XAML property element (6 warnings)**: `TwoPaneViewPage.xaml` had `BackgroundColor` on the `Pane1` property element, which is invalid and ignored at runtime. Moved the color to the child `Frame`, where it is a valid property and becomes effective.

### Not addressed (intentional/external)

- **RS0016/RS0017** - No final PublicAPI changes remain in this PR; those Essentials.AI API entries are already handled on `main`.
- **XC0022/XC0023/XC0045/XC0618/MAUIG2045** (125 warnings) - Intentional in `Controls.Xaml.UnitTests` test project (configured via `WarningsNotAsErrors`).
- **MSB3021/3026/3027** - Transient file-locking during parallel CI builds.
- **XA0141** - Third-party NuGet (`Gee.External.Capstone`) 16KB page alignment warning in benchmarks.

---

🏁 Report — Final Recommendation

Comparative Report — PR #34629

Candidates Compared

Rank	Candidate	Test Result	Assessment
1	pr	⚠ INCONCLUSIVE	Localized sample/tooling fix with no code correctness findings: removes duplicate splash entry, moves invalid XAML background to a valid Frame property, and updates the Android sample manifest target SDK to 36.
2	pr-plus-reviewer	⚠ INCONCLUSIVE	Functionally identical to pr because the expert reviewer produced no actionable findings and inline-findings.json is [].
3	try-fix-1	⚠ BLOCKED	Avoids a hardcoded manifest target SDK, but validation was blocked by workload resolution and the approach risks generated minSdkVersion drift after removing <uses-sdk> entirely.
4	try-fix-2	❌ FAIL	Failed with product-relevant XA1036 because the retained manifest minSdkVersion=23 conflicted with the repo-evaluated Android SupportedOSPlatformVersion=21.0.
5	try-fix-3	❌ FAIL	Avoided XA1036, but broadened the change to repo Android defaults and failed restore/build with net10.0-android36.0 asset target mismatches in project references.

Analysis

The raw PR fix is the best candidate. It is narrowly scoped to sample/tooling files, avoids the empirically observed failures from the MSBuild/TFM alternatives, and has no actionable expert-review findings. The gate is inconclusive rather than failing, so it does not rank below failed alternatives.

pr-plus-reviewer does not improve on pr because the expert reviewer found no changes to apply. It remains a valid PR-fix candidate, but ranking it above pr would imply a material improvement that does not exist.

The try-fix candidates are lower-ranked because none passed validation or demonstrated a safer outcome. Per the ranking rule, the failed regression/build candidates (try-fix-2, try-fix-3) are ranked below the non-failing PR candidates. try-fix-1 is also below the PR because it was blocked and carries a concrete risk of changing generated Android manifest semantics.

Winning Candidate

Winner: pr

Rationale: The submitted PR is the only localized candidate that avoids the proven XA1036 and asset-graph failures while addressing the remaining warning-producing sample changes. Expert review found no actionable code issues, and the inconclusive gate is not evidence of a failing fix.

---

🧭 Next Steps — review latest findings

No alternative fix was selected for this run. Review the session findings and CI results before merging.