-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Testing] Refactoring Feature Matrix UITest Cases for Editor Control #34615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LogishaSelvarajSF4525
wants to merge
10
commits into
dotnet:main
Choose a base branch
from
LogishaSelvarajSF4525:refactoring-editor-feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
34c0c65
updated the sample
LogishaSelvarajSF4525 fceac24
rename the snapshot
LogishaSelvarajSF4525 3a8b46d
updated the sample & test cases
LogishaSelvarajSF4525 94a9ae7
added the snapshots
LogishaSelvarajSF4525 6fcea3c
updated the test caess
LogishaSelvarajSF4525 157dc8f
updated the test cases
LogishaSelvarajSF4525 d31ab62
added the snapshot
LogishaSelvarajSF4525 ffe8f19
update the order number sequence
LogishaSelvarajSF4525 62766ac
added the issue link
LogishaSelvarajSF4525 30ba70b
updated the opacity property
LogishaSelvarajSF4525 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
Binary file removed
BIN
-38.6 KB
...ests/snapshots/android-notch-36/VerifyzEditorPlaceholderWithAutoSizeDiabled.png
Binary file not shown.
Binary file removed
BIN
-54.8 KB
.../snapshots/android-notch-36/VerifyzEditorPlaceholderWithAutoSizeTextChanges.png
Binary file not shown.
Binary file added
BIN
+19.7 KB
...ases.Android.Tests/snapshots/android/VerifyEditorBackgroundColorResetToNone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+20.2 KB
....Android.Tests/snapshots/android/VerifyEditorBackgroundColorWithPlaceholder.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+19.8 KB
...es.Android.Tests/snapshots/android/VerifyEditorBackgroundColorWithTextColor.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+20 KB
...ts/snapshots/android/VerifyEditorControlWhenPlaceholderColorSetDefaultValue.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-177 Bytes
(99%)
...s.Android.Tests/snapshots/android/VerifyEditorControlWhenPlaceholderTextSet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+20.5 KB
...shots/android/VerifyEditorPlaceholderTextWhenFontAttributesBoldAndItalicSet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-180 Bytes
(99%)
...Android.Tests/snapshots/android/VerifyEditorPlaceholderWhenFlowDirectionSet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-29.1 KB
....Android.Tests/snapshots/android/VerifyEditorPlaceholderWithAutoSizeDiabled.png
Binary file not shown.
Binary file removed
BIN
-38.7 KB
...roid.Tests/snapshots/android/VerifyEditorPlaceholderWithAutoSizeTextChanges.png
Binary file not shown.
Binary file modified
BIN
-181 Bytes
(99%)
...Android.Tests/snapshots/android/VerifyEditorPlaceholderWithCharacterSpacing.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-204 Bytes
(99%)
...s.Android.Tests/snapshots/android/VerifyEditorPlaceholderWithFontAttributes.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-220 Bytes
(99%)
...Cases.Android.Tests/snapshots/android/VerifyEditorPlaceholderWithFontFamily.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-312 Bytes
(99%)
...stCases.Android.Tests/snapshots/android/VerifyEditorPlaceholderWithFontSize.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-178 Bytes
(99%)
...roid.Tests/snapshots/android/VerifyEditorPlaceholderWithHorizontalAlignment.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.38 KB
(91%)
...TestCases.Android.Tests/snapshots/android/VerifyEditorPlaceholderWithShadow.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-177 Bytes
(99%)
...ndroid.Tests/snapshots/android/VerifyEditorPlaceholderWithVerticalAlignment.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+19.7 KB
...tCases.Android.Tests/snapshots/android/VerifyEditorTextColorSetDefaultValue.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
File renamed without changes
Binary file removed
BIN
-25.1 KB
...tCases.Android.Tests/snapshots/android/VerifyEditorTextWhenAutoSizeDisabled.png
Diff not rendered.
Binary file removed
BIN
-39.5 KB
....Android.Tests/snapshots/android/VerifyEditorTextWhenAutoSizeTextChangesSet.png
Diff not rendered.
Binary file added
BIN
+20.5 KB
....Tests/snapshots/android/VerifyEditorTextWhenFontAttributesBoldAndItalicSet.png
Oops, something went wrong.
Binary file added
BIN
+19 KB
...estCases.Android.Tests/snapshots/android/VerifyEditorWhenBackgroundColorSet.png
Oops, something went wrong.
Binary file added
BIN
+19.7 KB
...es.Android.Tests/snapshots/android/VerifyEditorWhenHeightAndWidthRequestSet.png
Oops, something went wrong.
Binary file added
BIN
+19.7 KB
.../TestCases.Android.Tests/snapshots/android/VerifyEditorWhenHeightRequestSet.png
Oops, something went wrong.
Binary file added
BIN
+19.7 KB
...Cases.Android.Tests/snapshots/android/VerifyEditorWhenOpacityResetToDefault.png
Oops, something went wrong.
Binary file added
BIN
+19.4 KB
.../tests/TestCases.Android.Tests/snapshots/android/VerifyEditorWhenOpacitySet.png
Oops, something went wrong.
Binary file added
BIN
+19.7 KB
...s/TestCases.Android.Tests/snapshots/android/VerifyEditorWhenWidthRequestSet.png
Oops, something went wrong.
File renamed without changes
Binary file removed
BIN
-25.7 KB
...Android.Tests/snapshots/android/VerifyzEditorPlaceholderWithAutoSizeDiabled.png
Diff not rendered.
Binary file removed
BIN
-47.3 KB
...oid.Tests/snapshots/android/VerifyzEditorPlaceholderWithAutoSizeTextChanges.png
Diff not rendered.
Binary file removed
BIN
-48.5 KB
...Cases.Android.Tests/snapshots/android/VerifyzEditorTextWhenAutoSizeDisabled.png
Diff not rendered.
Binary file removed
BIN
-48.5 KB
...Android.Tests/snapshots/android/VerifyzEditorTextWhenAutoSizeTextChangesSet.png
Diff not rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
205 changes: 132 additions & 73 deletions
205
src/Controls/tests/TestCases.HostApp/FeatureMatrix/Editor/EditorOptionsPage.xaml
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PlaceholderColorButton_Clickeddoesn’t handle the newPlaceholderColorDefaultAutomationId. As a result, tapping the “Default” placeholder color button is a no-op (it falls through to_ => _viewModel.PlaceholderColor), so tests that expect the placeholder color to reset to the default will fail. Update the switch to mapPlaceholderColorDefault(and/or the default case) tonullso the placeholder color actually resets.