-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[AI] Sample: Detail page, semantic search, streaming, and UI polish #34576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4205f28
AI Sample: Landmark detail page, semantic search, UX improvements
mattleibow c584171
Polish Essentials AI sample: UI improvements and bug fixes
mattleibow 65f5ed0
Update LandmarksPage.xaml.cs
mattleibow 8ef298a
AI Sample: Schema middleware, chat fixes, weather, language refactor,…
mattleibow 4c90bf2
Add StreamingResponseHandler passthrough mode + tests
mattleibow 792cbf8
Add streaming device tests (DeliversMultipleIncrementalUpdates, Conca…
mattleibow e81bcd1
Revert csproj to main (Windows manifest props belong in Windows PR)
mattleibow b342d97
Use the correct attribute
mattleibow 47c929b
Use DisplayName instead of JsonPropertyName for schema compatibility
mattleibow 178f1f0
Revert to JsonPropertyName for record properties
mattleibow e61cdee
Address PR review comments: fix IsVisible converters, language tip, a…
mattleibow 1bd8424
Address PR review comments: fix IsVisible converters, language tip, a…
mattleibow 2035b1a
Make ISemanticSearchService non-nullable in DataService
mattleibow aa6fa0f
Address round 3 review comments
mattleibow 41e7c2f
Revert "Address PR review comments: fix IsVisible converters, languag…
mattleibow 741a6b7
Replace emoji with FluentSystemIcons in AI sample app
mattleibow 96cdecf
Move FluentUI.cs out of Resources/Fonts to fix CI build
mattleibow b14bdb5
Trigger CI rebuild
mattleibow b2eb0ec
Move GetWeatherIcon out of Weather.cs model
mattleibow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
src/AI/samples/Essentials.AI.Sample/Converters/IsPositiveConverter.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| using System.Globalization; | ||
|
|
||
| namespace Maui.Controls.Sample.Converters; | ||
|
|
||
| public class IsPositiveConverter : IValueConverter | ||
| { | ||
| public object Convert(object? value, Type targetType, object? parameter, CultureInfo culture) | ||
| { | ||
| return value is int i && i > 0; | ||
| } | ||
|
|
||
| public object ConvertBack(object? value, Type targetType, object? parameter, CultureInfo culture) | ||
| { | ||
| throw new NotImplementedException(); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment says “Short JSON names (dest/days/lang) prevent misspelling…”, but TravelPlanResult uses JsonPropertyName("place"), "days", and "language". Consider updating the remark to match the actual short names (place/days/language) to avoid confusion when editing prompts/schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in aa6fa0f — updated comment to say \place/days/language\ to match the actual \JsonPropertyName\ values.