-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix Flyout memory leak #34485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix Flyout memory leak #34485
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6c9a6c7
call DisconnectHandler
pictos 96d33dc
clean up StackNavigationManager
pictos 3bf02a4
Nullingout the _navigationManager
pictos f487e20
clean up NavigationViewFragment
pictos 05ded57
fix rebase
pictos b194e70
add memory test
pictos e856ffa
improve tests
pictos d6b1bfc
revert teh oldHost.Dispose call
pictos 7e29821
code review
pictos 8e5783c
change call to DisconnetHandler
pictos bfbdb29
repro for memory leak (to be reverted)
pictos 3d6130d
change the cleanup order
pictos d9a0bf2
Revert "repro for memory leak (to be reverted)"
pictos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.