-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix Flyout memory leak #34485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Flyout memory leak #34485
Changes from 10 commits
6c9a6c7
96d33dc
3bf02a4
f487e20
05ded57
b194e70
e856ffa
d6b1bfc
7e29821
8e5783c
bfbdb29
3d6130d
d9a0bf2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -87,8 +87,14 @@ public override void OnResume() | |||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| public override void OnDestroy() | ||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||
| if (_currentView is not null) | ||||||||||||||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can get rid of this block and only need the code that sets the nav manager to null
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After removing this block, the leak gets worse. You can see the stats in the table
|
||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||
| _fragmentContainerView?.RemoveView(_currentView); | ||||||||||||||||||||||||||||||||
| _currentView.RemoveFromParent(); | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
| _currentView = null; | ||||||||||||||||||||||||||||||||
| _fragmentContainerView = null; | ||||||||||||||||||||||||||||||||
| _navigationManager = null; | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| base.OnDestroy(); | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.