[release/10.0.1xx-sr5] [Regression] Fix TypedBinding nested property re-subscription (#34428)#34450
Merged
PureWeen merged 1 commit intorelease/10.0.1xx-sr5from Mar 13, 2026
Conversation
Member
|
/azp run maui-pr-uitests, maui-pr-devicetests |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Mar 12, 2026
…ate becomes non-null When an intermediate object in a TypedBinding path starts as null and later becomes non-null (or is replaced with a different object), the binding must re-establish INPC subscriptions to the new object's nested properties. The previous optimization used a '_isSubscribed' boolean flag to skip IPropertyChangeHandler.Subscribe() after the first Apply. This prevented re-subscribing when intermediate objects changed. For example: vm.Child = null // subscribe to vm, but NOT vm.Child.Name (null) vm.Child = new Child() // Subscribe skipped due to _isSubscribed=true vm.Child.Name = "x" // binding never fires — regression! The fix removes '_isSubscribed' and always calls Subscribe on each Apply. Both IPropertyChangeHandler implementations (PropertyChangeHandler and LegacyPropertyChangeHandler) are already idempotent — they use reference equality checks to avoid re-subscribing to unchanged objects — so calling Subscribe on every Apply is safe and has minimal overhead. Adds two regression tests: - TypedBinding_NestedProperty_ResubscribesAfterNullIntermediateBecomesNonNull - TypedBinding_NestedProperty_ResubscribesAfterIntermediateReplaced Reported in: #32382 (comment) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
bot
force-pushed
the
backport/pr-34449-to-release/10.0.1xx-sr5
branch
from
b9528f1 to
12c693e
Compare
PureWeen
approved these changes
Mar 13, 2026
This was referenced Mar 25, 2026
Merged
Open
evgenygunko
pushed a commit
to evgenygunko/CopyWordsDA
that referenced
this pull request
Mar 26, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Microsoft.Maui.Controls](https://github.com/dotnet/maui) | nuget | patch | `10.0.50` -> `10.0.51` | --- ### Release Notes <details> <summary>dotnet/maui (Microsoft.Maui.Controls)</summary> ### [`v10.0.51`](https://github.com/dotnet/maui/releases/tag/10.0.51): SR5.1 [Compare Source](dotnet/maui@10.0.50...10.0.51) #### What's Changed - Increment patch version from 50 to 51 by [@​PureWeen](https://github.com/PureWeen) in dotnet/maui#34458 - \[release/10.0.1xx-sr5] \[Regression] Fix TypedBinding nested property re-subscription ([#​34428](dotnet/maui#34428)) by [@​github-actions](https://github.com/github-actions)\[bot] in dotnet/maui#34450 - \[backport 10.0.1xx-sr5] Fix MAUIG2045 false positive with x:Reference source in DataTemplate by [@​StephaneDelcroix](https://github.com/StephaneDelcroix) in dotnet/maui#34525 **Full Changelog**: dotnet/maui@10.0.50...10.0.51 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!". 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
This was referenced Mar 26, 2026
Open
Merged
TheCodeTraveler
pushed a commit
to TheCodeTraveler/MAUIChatGPTClone
that referenced
this pull request
Mar 26, 2026
Updated [Microsoft.Maui.Controls](https://github.com/dotnet/maui) from 10.0.50 to 10.0.51. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Maui.Controls's releases](https://github.com/dotnet/maui/releases)._ ## 10.0.51 ## What's Changed * Increment patch version from 50 to 51 by @PureWeen in dotnet/maui#34458 * [release/10.0.1xx-sr5] [Regression] Fix TypedBinding nested property re-subscription (#34428) by @github-actions[bot] in dotnet/maui#34450 * [backport 10.0.1xx-sr5] Fix MAUIG2045 false positive with x:Reference source in DataTemplate by @StephaneDelcroix in dotnet/maui#34525 **Full Changelog**: dotnet/maui@10.0.50...10.0.51 Commits viewable in [compare view](dotnet/maui@10.0.50...10.0.51). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Mar 27, 2026
Open
This was referenced Mar 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #34449 to release/10.0.1xx-sr5
/cc @StephaneDelcroix