Fix dogfood scripts: workflow trigger, build detection, and in-progress handling

[jfversluis]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description

Three fixes for the dogfooding infrastructure that was merged in #33198 but never worked correctly:

1. Workflow trigger fix (dogfood-comment.yml)

The workflow was changed from pull_request_target to check_run trigger in #33198, but Azure DevOps check runs never populate the pull_requests[] array. This means github.event.check_run.pull_requests[0] != null was always false, and the workflow never ran.

Fix: Reverted to pull_request_target trigger with a comment explaining why check_run does not work.

2. AzDO direct fallback (both scripts)

When the GitHub Checks API does not return build info (which can happen for merge commits or in certain timing windows), the scripts now fall back to querying the Azure DevOps API directly using refs/pull/{PR}/merge branch name.

This approach is modeled after the working implementation in maui-version.

3. In-progress build detection (both scripts)

When no completed build is found, the scripts now query AzDO for builds with status in ("inProgress", "notStarted", "postponed"). Instead of the generic "no build found" error, users now see:

• Build in progress: "A build is currently in progress. Please wait for it to complete."
• Stale artifacts: When an older build has artifacts but a newer build is running, warns users

Additional improvements

• Build ID numeric validation to prevent URL injection
• PR number validation in bash script
• Protection against set -e crashes on invalid jq input
• Better error messages for all failure scenarios

Testing

Tested locally with multiple real PRs across both scripts:

• ✅ PR [build] clean up old $(DebugType) MSBuild settings #34216 (completed, successful) - both scripts find build and apply artifacts
• ✅ PR [iOS] Fix: invoke MediaPicker completion handler after DismissViewController #34250 (in-progress build) - correctly finds existing artifacts with warning
• ✅ PR #99999999 (non-existent) - proper error handling
• ✅ Invalid PR number ("abc") - input validation works
• ✅ Multi-model code review (Claude Sonnet 4.5, GPT-5.1, Gemini 3 Pro) - all findings addressed

[Copilot]

Pull request overview

This PR fixes three critical issues in the dogfooding infrastructure that prevented it from working correctly after its initial merge in #33198: workflow trigger incompatibility with Azure DevOps check runs, missing fallback for querying build information directly from Azure DevOps, and lack of in-progress build detection.

Changes:

• Reverted workflow trigger from check_run to pull_request_target with explanation of Azure DevOps limitation
• Added Azure DevOps API fallback for finding builds when GitHub Checks API doesn't return results
• Implemented in-progress build detection to provide better user feedback instead of generic errors

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
.github/workflows/dogfood-comment.yml	Fixed workflow trigger to use pull_request_target instead of check_run due to Azure DevOps limitation
eng/scripts/get-maui-pr.sh	Added AzDO fallback, in-progress detection, input validation, and improved error messages
eng/scripts/get-maui-pr.ps1	Added AzDO fallback, in-progress detection, and improved error messages

Comments suppressed due to low confidence (3)

eng/scripts/get-maui-pr.sh:191

• The jq filter logic for checking in-progress builds is duplicated in lines 191 and 262. Consider extracting this filter pattern into a variable or using the check_build_in_progress function instead of repeating the jq query.

    in_progress=$(echo "$builds_json" | jq -r '[.value[] | select(.definition.name == "maui-pr" and (.status == "inProgress" or .status == "notStarted" or .status == "postponed"))] | length' 2>/dev/null || echo "0")

eng/scripts/get-maui-pr.sh:248

• When jq fails or returns invalid JSON, the fallback || echo \"\" produces an empty string, but this isn't distinguishing between 'no completed builds' and 'jq failed to parse the response'. Consider adding explicit error handling to differentiate between API errors and legitimately empty results.

        completed_build=$(echo "$builds_json" | jq -r '[.value[] | select(.definition.name == "maui-pr" and .status == "completed")] | first | @json' 2>/dev/null || echo "")

eng/scripts/get-maui-pr.ps1:225

• The build ID validation uses string interpolation \"$($completedBuild.id)\" which could mask issues if the id property is null or missing. Consider using -not ($completedBuild.id -is [int]) or checking for null explicitly before the regex match.

            if ("$($completedBuild.id)" -notmatch '^\d+$') {